Skip to content

Commit 0cc1a5c

Browse files
author
Chad Little
committed
Clean up Space select/dropdown UI alignment
Summary: This alignment is off on edit forms, from the new overflow rules. Let's re-align everything for forms too. Test Plan: Add 2 new spaces, go to Maniphest, edit a task, see proper alignment of [Space] [Policy] view dropdowns. Check mobile alignment and Safari/FF. {F3942187} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D17491
1 parent 4457c38 commit 0cc1a5c

File tree

3 files changed

+23
-6
lines changed

3 files changed

+23
-6
lines changed

resources/celerity/map.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
'names' => array(
1010
'conpherence.pkg.css' => '6875302f',
1111
'conpherence.pkg.js' => '6249a1cf',
12-
'core.pkg.css' => '49a02d1f',
12+
'core.pkg.css' => '35645dec',
1313
'core.pkg.js' => '1fa7c0c5',
1414
'darkconsole.pkg.js' => 'e7393ebb',
1515
'differential.pkg.css' => '90b30783',
@@ -134,7 +134,7 @@
134134
'rsrc/css/phui/phui-basic-nav-view.css' => 'a0705f53',
135135
'rsrc/css/phui/phui-big-info-view.css' => 'bd903741',
136136
'rsrc/css/phui/phui-box.css' => '269cbc99',
137-
'rsrc/css/phui/phui-button.css' => 'c55204db',
137+
'rsrc/css/phui/phui-button.css' => '14bfba79',
138138
'rsrc/css/phui/phui-chart.css' => '6bf6f78e',
139139
'rsrc/css/phui/phui-cms.css' => '504b4b23',
140140
'rsrc/css/phui/phui-comment-form.css' => '48fbd65d',
@@ -147,7 +147,7 @@
147147
'rsrc/css/phui/phui-feed-story.css' => '44a9c8e9',
148148
'rsrc/css/phui/phui-fontkit.css' => 'b78a0059',
149149
'rsrc/css/phui/phui-form-view.css' => 'adca31ce',
150-
'rsrc/css/phui/phui-form.css' => '5815af7b',
150+
'rsrc/css/phui/phui-form.css' => 'b62c01d8',
151151
'rsrc/css/phui/phui-head-thing.css' => 'fd311e5f',
152152
'rsrc/css/phui/phui-header-view.css' => 'fef6a54e',
153153
'rsrc/css/phui/phui-hovercard.css' => 'ae091fc5',
@@ -841,7 +841,7 @@
841841
'phui-basic-nav-view-css' => 'a0705f53',
842842
'phui-big-info-view-css' => 'bd903741',
843843
'phui-box-css' => '269cbc99',
844-
'phui-button-css' => 'c55204db',
844+
'phui-button-css' => '14bfba79',
845845
'phui-calendar-css' => '477acfaa',
846846
'phui-calendar-day-css' => '572b1893',
847847
'phui-calendar-list-css' => '576be600',
@@ -858,7 +858,7 @@
858858
'phui-feed-story-css' => '44a9c8e9',
859859
'phui-font-icon-base-css' => '870a7360',
860860
'phui-fontkit-css' => 'b78a0059',
861-
'phui-form-css' => '5815af7b',
861+
'phui-form-css' => 'b62c01d8',
862862
'phui-form-view-css' => 'adca31ce',
863863
'phui-head-thing-view-css' => 'fd311e5f',
864864
'phui-header-view-css' => 'fef6a54e',

webroot/rsrc/css/phui/phui-button.css

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,12 @@ a.policy-control .phui-button-text {
242242
display: block;
243243
}
244244

245+
.device-phone a.button.policy-control {
246+
display: block;
247+
float: none;
248+
width: auto;
249+
}
250+
245251
.caret {
246252
display: inline-block;
247253
width: 0;

webroot/rsrc/css/phui/phui-form.css

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,9 +157,20 @@ textarea[disabled],
157157
}
158158

159159
.aphront-space-select-control-knob {
160-
margin: 2px 8px 2px 0;
160+
margin: 0 8px 0 0;
161+
float: left;
162+
}
163+
164+
.aphront-form-control-policy .policy-control {
165+
float: left;
166+
margin-right: 8px;
161167
}
162168

163169
.device .aphront-space-select-control-knob {
164170
margin-bottom: 8px;
171+
float: none;
172+
}
173+
174+
.device .aphront-form-control-policy .policy-control {
175+
margin: 0;
165176
}

0 commit comments

Comments
 (0)