Skip to content

Commit 648fa2e

Browse files
committedJan 6, 2015
Repositories - Move scripts/repository/reparse.php to bin/repository reparse
Summary: Fixes T5966. Accomplishes a few things - see title - adds a force-autoclose flag and the plumbing for it - removes references to some HarborMaster thing that used to key off commits and seems long dead, but forgotten :/ Test Plan: ran a few commands. These first three had great success: `./repository reparse --all FIRSTREPO --message --change --herald --owners` `./repository reparse --all FIRSTREPO --message --change --herald --owners --min-date yesterday` `./repository reparse --all FIRSTREPO --message --change --herald --owners --min-date yesterday --force-autoclose` ...and these next two showed me some errors as expected: `./repository reparse --all FIRSTREPO --message --change --herald --owners --min-date garbagedata` `./repository reparse --all GARBAGEREPO --message --change --herald --owners` Also, made a diff in a repository with autoclose disabled and commited the diff. Later, reparse the diff with force-autoclose. Verified the diff closed and that the reason "why" had the proper message text. Reviewers: epriestley Reviewed By: epriestley Subscribers: joshuaspence, epriestley, Korvin Maniphest Tasks: T5966 Differential Revision: https://secure.phabricator.com/D10492
1 parent 3e421c7 commit 648fa2e

File tree

6 files changed

+324
-299
lines changed

6 files changed

+324
-299
lines changed
 

‎scripts/repository/reparse.php

-297
This file was deleted.

‎src/__phutil_library_map__.php

+2
Original file line numberDiff line numberDiff line change
@@ -2284,6 +2284,7 @@
22842284
'PhabricatorRepositoryManagementParentsWorkflow' => 'applications/repository/management/PhabricatorRepositoryManagementParentsWorkflow.php',
22852285
'PhabricatorRepositoryManagementPullWorkflow' => 'applications/repository/management/PhabricatorRepositoryManagementPullWorkflow.php',
22862286
'PhabricatorRepositoryManagementRefsWorkflow' => 'applications/repository/management/PhabricatorRepositoryManagementRefsWorkflow.php',
2287+
'PhabricatorRepositoryManagementReparseWorkflow' => 'applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php',
22872288
'PhabricatorRepositoryManagementUpdateWorkflow' => 'applications/repository/management/PhabricatorRepositoryManagementUpdateWorkflow.php',
22882289
'PhabricatorRepositoryManagementWorkflow' => 'applications/repository/management/PhabricatorRepositoryManagementWorkflow.php',
22892290
'PhabricatorRepositoryMercurialCommitChangeParserWorker' => 'applications/repository/worker/commitchangeparser/PhabricatorRepositoryMercurialCommitChangeParserWorker.php',
@@ -5524,6 +5525,7 @@
55245525
'PhabricatorRepositoryManagementParentsWorkflow' => 'PhabricatorRepositoryManagementWorkflow',
55255526
'PhabricatorRepositoryManagementPullWorkflow' => 'PhabricatorRepositoryManagementWorkflow',
55265527
'PhabricatorRepositoryManagementRefsWorkflow' => 'PhabricatorRepositoryManagementWorkflow',
5528+
'PhabricatorRepositoryManagementReparseWorkflow' => 'PhabricatorRepositoryManagementWorkflow',
55275529
'PhabricatorRepositoryManagementUpdateWorkflow' => 'PhabricatorRepositoryManagementWorkflow',
55285530
'PhabricatorRepositoryManagementWorkflow' => 'PhabricatorManagementWorkflow',
55295531
'PhabricatorRepositoryMercurialCommitChangeParserWorker' => 'PhabricatorRepositoryCommitChangeParserWorker',

‎src/applications/diffusion/controller/DiffusionCommitEditController.php

+4
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ public function processRequest() {
6767
->setDatasource(new PhabricatorProjectDatasource()));
6868

6969
$reason = $data->getCommitDetail('autocloseReason', false);
70+
$reason = PhabricatorRepository::BECAUSE_AUTOCLOSE_FORCED;
7071
if ($reason !== false) {
7172
switch ($reason) {
7273
case PhabricatorRepository::BECAUSE_REPOSITORY_IMPORTING:
@@ -78,6 +79,9 @@ public function processRequest() {
7879
case PhabricatorRepository::BECAUSE_NOT_ON_AUTOCLOSE_BRANCH:
7980
$desc = pht('No, Not On Autoclose Branch');
8081
break;
82+
case PhabricatorRepository::BECAUSE_AUTOCLOSE_FORCED:
83+
$desc = pht('Yes, Forced Via bin/repository CLI Tool.');
84+
break;
8185
case null:
8286
$desc = pht('Yes');
8387
break;

0 commit comments

Comments
 (0)
Failed to load comments.