Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: phacility/phabricator
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: txchen/phabricator
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Able to merge. These branches can be automatically merged.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Nov 4, 2021

  1. Optimize file object policy checks. 

    Skip checking file's view policy if it is public or all_users.
    @txchen
    txchen committed Nov 4, 2021
    Copy the full SHA
    27f7e6e View commit details
Showing with 6 additions and 0 deletions.
  1. +6 −0 src/applications/files/query/PhabricatorFileQuery.php
6 changes: 6 additions & 0 deletions src/applications/files/query/PhabricatorFileQuery.php
View file
Original file line number Diff line number Diff line change
@@ -183,6 +183,12 @@ protected function loadPage() {
$always_visible = true;
}

$file_view_policy = $file->getViewPolicy();
if ($file_view_policy == PhabricatorPolicies::POLICY_PUBLIC ||
$file_view_policy == PhabricatorPolicies::POLICY_USER) {
$always_visible = true;
}

if ($always_visible) {
// We just treat these files as though they aren't attached to
// anything. This saves a query in common cases when we're loading