Fix impropery history graph trace in Mercurial

epriestley · epriestley · commit 2a1393c008c3 · 2016-07-04T10:24:14.000-07:00
Summary: Fixes T11267. This data was coming back weird (in reverse order relative to the graph itself). Previously it worked OK anyway, but the new logic is a little more sensitive to the input. Test Plan: Viewed a Mercurial repository with linear history, saw linear history. Reviewers: chad Reviewed By: chad Maniphest Tasks: T11267 Differential Revision: https://secure.phabricator.com/D16229
diff --git a/src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php
@@ -173,7 +173,7 @@ protected function getMercurialResult(ConduitAPIRequest $request) {
     }
 
     $hash_list = array_reverse($hash_list);
-    $this->parents = $parent_map;
+    $this->parents = array_reverse($parent_map, true);
 
     return DiffusionQuery::loadHistoryForCommitIdentifiers(
       $hash_list,

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ protected function getMercurialResult(ConduitAPIRequest $request) {`
`173`	`173`	`}`
`174`	`174`
`175`	`175`	`$hash_list = array_reverse($hash_list);`
`176`		`- $this->parents = $parent_map;`
	`176`	`+ $this->parents = array_reverse($parent_map, true);`
`177`	`177`
`178`	`178`	`return DiffusionQuery::loadHistoryForCommitIdentifiers(`
`179`	`179`	`$hash_list,`