Don't wrap task/revision titles in graph tables

epriestley · epriestley · commit 62131de8cd16 · 2016-07-05T08:00:18.000-07:00
Summary: Fixes T11274. When task titles are long, we currently wrap stuff and the trace graph renders real weird. Instead, prevent taks/revision titles from wrapping/overflowing. (This works in a slightly weird way, and `text-overflow: ellipsis;` has no apparent effect on any of the containers.) Test Plan: {F1712394} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11274 Differential Revision: https://secure.phabricator.com/D16233
diff --git a/src/infrastructure/graph/DifferentialRevisionGraph.php b/src/infrastructure/graph/DifferentialRevisionGraph.php
@@ -54,6 +54,8 @@ protected function newTableRow($phid, $object, $trace) {
       $link = $viewer->renderHandle($phid);
     }
 
+    $link = AphrontTableView::renderSingleDisplayLine($link);
+
     return array(
       $trace,
       $status,
diff --git a/src/infrastructure/graph/ManiphestTaskGraph.php b/src/infrastructure/graph/ManiphestTaskGraph.php
@@ -67,6 +67,8 @@ protected function newTableRow($phid, $object, $trace) {
       $link = $viewer->renderHandle($phid);
     }
 
+    $link = AphrontTableView::renderSingleDisplayLine($link);
+
     return array(
       $trace,
       $status,

Original file line number	Diff line number	Diff line change
`@@ -54,6 +54,8 @@ protected function newTableRow($phid, $object, $trace) {`
`54`	`54`	`$link = $viewer->renderHandle($phid);`
`55`	`55`	`}`
`56`	`56`
	`57`	`+ $link = AphrontTableView::renderSingleDisplayLine($link);`
	`58`	`+`
`57`	`59`	`return array(`
`58`	`60`	`$trace,`
`59`	`61`	`$status,`
Original file line number	Diff line number	Diff line change
`@@ -67,6 +67,8 @@ protected function newTableRow($phid, $object, $trace) {`
`67`	`67`	`$link = $viewer->renderHandle($phid);`
`68`	`68`	`}`
`69`	`69`
	`70`	`+ $link = AphrontTableView::renderSingleDisplayLine($link);`
	`71`	`+`
`70`	`72`	`return array(`
`71`	`73`	`$trace,`
`72`	`74`	`$status,`