Merge "Table of Contents", "Local Commits", "Update History" and "Similar Revisions"

Summary: Ref T10628. Turn these into tabs in a single box, since "local commits" and "similar revisions" are of particularly rare use.

Test Plan: {F1707196}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10628

Differential Revision: https://secure.phabricator.com/D16209

Author: epriestley

src/applications/differential/controller/DifferentialController.php

@@ -28,8 +28,8 @@ protected function buildTableOfContents(
     $viewer = $this->getViewer();
 
     $toc_view = id(new PHUIDiffTableOfContentsListView())
-      ->setUser($viewer)
-      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY);
+      ->setViewer($viewer)
+      ->setBare(true);
 
     $have_owners = PhabricatorApplication::isClassInstalledForViewer(
       'PhabricatorOwnersApplication',

src/applications/differential/controller/DifferentialRevisionViewController.php

@@ -292,15 +292,15 @@ public function handleRequest(AphrontRequest $request) {
         '/differential/comment/inline/edit/'.$revision->getID().'/');
     }
 
-    $diff_history = id(new DifferentialRevisionUpdateHistoryView())
+    $history = id(new DifferentialRevisionUpdateHistoryView())
       ->setUser($viewer)
       ->setDiffs($diffs)
       ->setSelectedVersusDiffID($diff_vs)
       ->setSelectedDiffID($target->getID())
       ->setSelectedWhitespace($whitespace)
       ->setCommitsForLinks($commits_for_links);
 
-    $local_view = id(new DifferentialLocalCommitsView())
+    $local_table = id(new DifferentialLocalCommitsView())
       ->setUser($viewer)
       ->setLocalCommits(idx($props, 'local:commits'))
       ->setCommitsForLinks($commits_for_links);
@@ -324,6 +324,36 @@ public function handleRequest(AphrontRequest $request) {
       $visible_changesets,
       $target->loadCoverageMap($viewer));
 
+    $tab_group = id(new PHUITabGroupView())
+      ->addTab(
+        id(new PHUITabView())
+          ->setName(pht('Files'))
+          ->setKey('files')
+          ->appendChild($toc_view))
+      ->addTab(
+        id(new PHUITabView())
+          ->setName(pht('History'))
+          ->setKey('history')
+          ->appendChild($history))
+      ->addTab(
+        id(new PHUITabView())
+          ->setName(pht('Commits'))
+          ->setKey('commits')
+          ->appendChild($local_table));
+
+    if ($other_view) {
+      $tab_group->addTab(
+        id(new PHUITabView())
+          ->setName(pht('Similar'))
+          ->setKey('similar')
+          ->appendChild($other_view));
+    }
+
+    $tab_view = id(new PHUIObjectBoxView())
+      ->setHeaderText(pht('Revision Contents'))
+      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
+      ->addTabGroup($tab_group);
+
     $comment_form = null;
     if (!$viewer_is_anonymous) {
       $comment_form = $this->buildCommentForm($revision, $field_list);
@@ -348,15 +378,16 @@ public function handleRequest(AphrontRequest $request) {
             'The content of this revision is hidden until the author has '.
             'signed all of the required legal agreements.'));
     } else {
-      $footer[] =
-        array(
-          $diff_history,
-          $warning,
-          $local_view,
-          $toc_view,
-          $other_view,
-          $changeset_view,
-        );
+      $anchor = id(new PhabricatorAnchorView())
+        ->setAnchorName('toc')
+        ->setNavigationMarker(true);
+
+      $footer[] = array(
+        $anchor,
+        $warning,
+        $tab_view,
+        $changeset_view,
+      );
     }
 
     if ($comment_form) {
@@ -870,9 +901,9 @@ private function renderOtherRevisions(array $revisions) {
       ->setHeader(pht('Recent Similar Revisions'));
 
     $view = id(new DifferentialRevisionListView())
-      ->setHeader($header)
       ->setRevisions($revisions)
       ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
+      ->setNoBox(true)
       ->setUser($viewer);
 
     $phids = $view->getRequiredHandlePHIDs();

src/applications/differential/view/DifferentialLocalCommitsView.php

@@ -125,10 +125,7 @@ public function render() {
     $headers[] = pht('Date');
     $table->setHeaders($headers);
 
-    return id(new PHUIObjectBoxView())
-      ->setHeaderText(pht('Local Commits'))
-      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
-      ->setTable($table);
+    return $table;
   }
 
   private static function formatCommit($commit) {

src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php

@@ -303,10 +303,7 @@ public function render() {
         $show_diff,
       ));
 
-    return id(new PHUIObjectBoxView())
-      ->setHeaderText(pht('Revision Update History'))
-      ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
-      ->setTable($content);
+    return $content;
   }
 
   const STAR_NONE = 'none';

src/infrastructure/diff/view/PHUIDiffTableOfContentsListView.php

@@ -7,6 +7,7 @@ final class PHUIDiffTableOfContentsListView extends AphrontView {
   private $header;
   private $infoView;
   private $background;
+  private $bare;
 
   public function addItem(PHUIDiffTableOfContentsItemView $item) {
     $this->items[] = $item;
@@ -38,6 +39,15 @@ public function setInfoView(PHUIInfoView $infoview) {
     return $this;
   }
 
+  public function setBare($bare) {
+    $this->bare = $bare;
+    return $this;
+  }
+
+  public function getBare() {
+    return $this->bare;
+  }
+
   public function render() {
     $this->requireResource('differential-core-view-css');
     $this->requireResource('differential-table-of-contents-css');
@@ -160,6 +170,10 @@ public function render() {
       ->setAnchorName('toc')
       ->setNavigationMarker(true);
 
+    if ($this->bare) {
+      return $table;
+    }
+
     $header = id(new PHUIHeaderView())
       ->setHeader(pht('Table of Contents'));