Skip to content

Commit ceb395e

Browse files
author
epriestley
committedJul 1, 2016
Don't link object monograms in object graphs
Summary: Ref T4788. Test Plan: {F1708372} Reviewers: chad Reviewed By: chad Maniphest Tasks: T4788 Differential Revision: https://secure.phabricator.com/D16221
1 parent d3c327e commit ceb395e

File tree

4 files changed

+25
-16
lines changed

4 files changed

+25
-16
lines changed
 

‎resources/celerity/map.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
*/
88
return array(
99
'names' => array(
10-
'core.pkg.css' => 'd04e6f67',
10+
'core.pkg.css' => '55d9bb83',
1111
'core.pkg.js' => 'f2139810',
1212
'darkconsole.pkg.js' => 'e7393ebb',
1313
'differential.pkg.css' => '3e81ae60',
@@ -25,7 +25,7 @@
2525
'rsrc/css/aphront/notification.css' => '3f6c89c9',
2626
'rsrc/css/aphront/panel-view.css' => '8427b78d',
2727
'rsrc/css/aphront/phabricator-nav-view.css' => 'ac79a758',
28-
'rsrc/css/aphront/table-view.css' => 'aeb66852',
28+
'rsrc/css/aphront/table-view.css' => '8df59783',
2929
'rsrc/css/aphront/tokenizer.css' => '056da01b',
3030
'rsrc/css/aphront/tooltip.css' => '1a07aea8',
3131
'rsrc/css/aphront/typeahead-browse.css' => '8904346a',
@@ -536,7 +536,7 @@
536536
'aphront-list-filter-view-css' => '5d6f0526',
537537
'aphront-multi-column-view-css' => 'fd18389d',
538538
'aphront-panel-view-css' => '8427b78d',
539-
'aphront-table-view-css' => 'aeb66852',
539+
'aphront-table-view-css' => '8df59783',
540540
'aphront-tokenizer-control-css' => '056da01b',
541541
'aphront-tooltip-css' => '1a07aea8',
542542
'aphront-typeahead-control-css' => 'd4f16145',

‎src/infrastructure/graph/DifferentialRevisionGraph.php

+8-6
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,13 @@ protected function newTableRow($phid, $object, $trace) {
4141
array(
4242
'href' => $object->getURI(),
4343
),
44-
array(
45-
$object->getMonogram(),
46-
' ',
47-
$object->getTitle(),
48-
));
44+
$object->getTitle());
45+
46+
$link = array(
47+
$object->getMonogram(),
48+
' ',
49+
$link,
50+
);
4951
} else {
5052
$status = null;
5153
$author = null;
@@ -74,7 +76,7 @@ protected function newTable(AphrontTableView $table) {
7476
'threads',
7577
'graph-status',
7678
null,
77-
'wide object-link',
79+
'wide pri object-link',
7880
));
7981
}
8082

‎src/infrastructure/graph/ManiphestTaskGraph.php

+8-6
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,13 @@ protected function newTableRow($phid, $object, $trace) {
5454
array(
5555
'href' => $object->getURI(),
5656
),
57-
array(
58-
$object->getMonogram(),
59-
' ',
60-
$object->getTitle(),
61-
));
57+
$object->getTitle());
58+
59+
$link = array(
60+
$object->getMonogram(),
61+
' ',
62+
$link,
63+
);
6264
} else {
6365
$status = null;
6466
$assigned = null;
@@ -87,7 +89,7 @@ protected function newTable(AphrontTableView $table) {
8789
'threads',
8890
'graph-status',
8991
null,
90-
'wide object-link',
92+
'wide pri object-link',
9193
));
9294
}
9395

‎webroot/rsrc/css/aphront/table-view.css

+6-1
Original file line numberDiff line numberDiff line change
@@ -228,9 +228,14 @@ span.single-display-line-content {
228228
position: static;
229229
}
230230

231+
.aphront-table-view tr.closed td.object-link,
232+
.aphront-table-view tr.alt-closed td.object-link {
233+
text-decoration: line-through;
234+
color: rgba({$alphablack}, 0.5);
235+
}
236+
231237
.aphront-table-view tr.closed td.object-link a,
232238
.aphront-table-view tr.alt-closed td.object-link a {
233-
text-decoration: line-through;
234239
color: rgba({$alphablack}, 0.5);
235240
}
236241

0 commit comments

Comments
 (0)
Failed to load comments.