Skip to content

Commit d3c327e

Browse files
author
epriestley
committedJul 1, 2016
Set Maniphest status icons to grey for closed tasks in object graph view
Summary: See D16219. Test Plan: {F1708338} Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D16220
1 parent 962cae2 commit d3c327e

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed
 

‎resources/celerity/map.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
*/
88
return array(
99
'names' => array(
10-
'core.pkg.css' => '93eb0544',
10+
'core.pkg.css' => 'd04e6f67',
1111
'core.pkg.js' => 'f2139810',
1212
'darkconsole.pkg.js' => 'e7393ebb',
1313
'differential.pkg.css' => '3e81ae60',
@@ -25,7 +25,7 @@
2525
'rsrc/css/aphront/notification.css' => '3f6c89c9',
2626
'rsrc/css/aphront/panel-view.css' => '8427b78d',
2727
'rsrc/css/aphront/phabricator-nav-view.css' => 'ac79a758',
28-
'rsrc/css/aphront/table-view.css' => '2596314c',
28+
'rsrc/css/aphront/table-view.css' => 'aeb66852',
2929
'rsrc/css/aphront/tokenizer.css' => '056da01b',
3030
'rsrc/css/aphront/tooltip.css' => '1a07aea8',
3131
'rsrc/css/aphront/typeahead-browse.css' => '8904346a',
@@ -536,7 +536,7 @@
536536
'aphront-list-filter-view-css' => '5d6f0526',
537537
'aphront-multi-column-view-css' => 'fd18389d',
538538
'aphront-panel-view-css' => '8427b78d',
539-
'aphront-table-view-css' => '2596314c',
539+
'aphront-table-view-css' => 'aeb66852',
540540
'aphront-tokenizer-control-css' => '056da01b',
541541
'aphront-tooltip-css' => '1a07aea8',
542542
'aphront-typeahead-control-css' => 'd4f16145',

‎src/infrastructure/graph/ManiphestTaskGraph.php

+4-1
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,11 @@ protected function newTableRow($phid, $object, $trace) {
3030
$priority = $object->getPriority();
3131
$status_icon = ManiphestTaskStatus::getStatusIcon($status);
3232
$status_name = ManiphestTaskStatus::getTaskStatusName($status);
33-
$priority_color = ManiphestTaskPriority::getTaskPriorityColor($priority);
3433

34+
$priority_color = ManiphestTaskPriority::getTaskPriorityColor($priority);
35+
if ($object->isClosed()) {
36+
$priority_color = 'grey';
37+
}
3538

3639
$status = array(
3740
id(new PHUIIconView())->setIcon($status_icon, $priority_color),

‎webroot/rsrc/css/aphront/table-view.css

+1-4
Original file line numberDiff line numberDiff line change
@@ -235,10 +235,7 @@ span.single-display-line-content {
235235
}
236236

237237
.aphront-table-view tr.closed td.graph-status,
238-
.aphront-table-view tr.alt-closed td.graph-status {
239-
opacity: 0.5;
240-
}
241-
238+
.aphront-table-view tr.alt-closed td.graph-status,
242239
.object-graph-table em {
243240
color: {$lightgreytext};
244241
}

0 commit comments

Comments
 (0)
Failed to load comments.