Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How does execute_query_with_incremental_retry actually work? #939

Open
npetzall-vcc opened this issue Feb 10, 2025 · 0 comments
Open

How does execute_query_with_incremental_retry actually work? #939

npetzall-vcc opened this issue Feb 10, 2025 · 0 comments
Labels

Comments

@npetzall-vcc
Copy link

def execute_query_with_incremental_retry(self, max_retry=5):

It calls

Which iterates with a sleep and a sleep that uses a method argument, so I don't see how that sleep could be dynamic.

Python isn't my primary language, but I've made the assumption that the input argument, which is an int is passed by value and is not a mutable object, since it's an int.

In the sharepoint/client_context the settings object is local to the method, the _try_process_if_failed is an internal method that only modifies the settings object, since you only call execute_query_with_incremental_retry once, and it only calls execute_query_retry once. I don't understand how the modification of the settings can have any effect.

I would have expected a sleep instead inside of _try_process_if_failed, to impact the delay of the retry iteration in client_runtime_context.py

@vgrem vgrem added the question label Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants