Skip to content

[web-animations-1] Make commitStyles use an endpoint-inclusive active interval #11881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

[web-animations-1] Make commitStyles use an endpoint-inclusive active interval #11881

merged 1 commit into from
Jun 20, 2025

Conversation

@birtles
Copy link
Contributor

@birtles birtles commented Mar 10, 2025

Fixes #5394.

@birtles
Copy link
Contributor Author

birtles commented Mar 10, 2025

Leaving this as a draft until we've determined that this change is Web-compatible.

@birtles birtles mentioned this pull request Apr 25, 2025
Closed
@birtles birtles mentioned this pull request May 27, 2025
Open
@birtles birtles marked this pull request as ready for review June 9, 2025 05:13
@birtles birtles requested review from flackr and graouts June 9, 2025 05:13
@birtles
Copy link
Contributor Author

birtles commented Jun 9, 2025

Putting this up for review since the use counter data we've collected in Firefox suggests this change is safe to make.

There are WPT for this here and once this PR is merged, we'll rename commitStyles.tentative.html to commitStyles.html.

@birtles
Copy link
Contributor Author

birtles commented Jun 19, 2025

@flackr @graouts Review ping?

flackr
flackr approved these changes Jun 19, 2025
View reviewed changes
Copy link
Contributor

@flackr flackr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks! Sorry I didn't see this earlier. The examples are so much cleaner, I'm glad it looked reasonably safe :-).

@birtles
Copy link
Contributor Author

birtles commented Jun 20, 2025

Thank you!

@birtles birtles merged commit aa2e02d into main Jun 20, 2025
1 check passed
@hamishwillee hamishwillee mentioned this pull request Jul 28, 2025
Merged
philwo pushed a commit to philwo/chromium that referenced this pull request Oct 30, 2025
@canalun
Make commitStyles endpoint-inclusive
85c1f31 
This patch aligns commitStyles() behavior with a recent spec update. The
WPTs have been already updated and that's causing new failures in
Chromium. This patch fixes our implementation to pass these tests and to
align with the spec.

Spec: w3c/csswg-drafts#11881
Bug: 40715046
Change-Id: I57a24bb29bd350ef66778c1259a2bde3fa19c769
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6904038
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1538000}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flackr flackr

@graouts graouts

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[web-animations] Could commitStyles always write the end state of the animation?

3 participants

@birtles @flackr