Convert phutil_render_tag(X, Y, '...') to phutil_tag

Summary:
Created with spatch:

  lang=diff
  - phutil_render_tag
  + phutil_tag
    (X, Y, '...')

Then searched for `&` and `<` in the output and replaced them.

Test Plan: Loaded homepage.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4503

Author: vrana

src/aphront/console/plugin/DarkConsoleServicesPlugin.php

@@ -146,7 +146,7 @@ public function render() {
 
     $results[] =
       '<div class="dark-console-panel-header">'.
-        phutil_render_tag(
+        phutil_tag(
           'a',
           array(
             'href'  => $this->getRequestURI()->alter('__analyze__', true),

src/aphront/console/plugin/DarkConsoleXHProfPlugin.php

@@ -32,7 +32,7 @@ public function getXHProfRunID() {
   public function render() {
     if (!DarkConsoleXHProfPluginAPI::isProfilerAvailable()) {
       $href = PhabricatorEnv::getDoclink('article/Installation_Guide.html');
-      $install_guide = phutil_render_tag(
+      $install_guide = phutil_tag(
         'a',
         array(
           'href' => $href,
@@ -53,7 +53,7 @@ public function render() {
 
     $header =
       '<div class="dark-console-panel-header">'.
-        phutil_render_tag(
+        phutil_tag(
           'a',
           array(
             'href'  => $this->getRequestURI()->alter('__profile__', 'page'),

src/applications/auth/controller/PhabricatorMustVerifyEmailController.php

@@ -53,7 +53,7 @@ public function processRequest() {
             'action' => '/login/mustverify/',
             'method' => 'POST',
           ),
-          phutil_render_tag(
+          phutil_tag(
             'button',
             array(
             ),

src/applications/calendar/view/AphrontCalendarMonthView.php

@@ -159,18 +159,18 @@ private function renderCalendarHeader(DateTime $date) {
       $uri = new PhutilURI($uri);
       list($prev_year, $prev_month) = $this->getPrevYearAndMonth();
       $query = array('year' => $prev_year, 'month' => $prev_month);
-      $prev_link = phutil_render_tag(
+      $prev_link = phutil_tag(
         'a',
         array('href' => (string) $uri->setQueryParams($query)),
-        '←'
+        "\xE2\x86\x90"
       );
 
       list($next_year, $next_month) = $this->getNextYearAndMonth();
       $query = array('year' => $next_year, 'month' => $next_month);
-      $next_link = phutil_render_tag(
+      $next_link = phutil_tag(
         'a',
         array('href' => (string) $uri->setQueryParams($query)),
-        '→'
+        "\xE2\x86\x92"
       );
 
       $left_th = '<th>'.$prev_link.'</th>';

src/applications/countdown/controller/PhabricatorCountdownListController.php

@@ -28,7 +28,7 @@ public function processRequest() {
       $delete_button = null;
       if ($user->getIsAdmin() ||
           ($user->getPHID() == $timer->getAuthorPHID())) {
-        $edit_button = phutil_render_tag(
+        $edit_button = phutil_tag(
           'a',
           array(
             'class' => 'small button grey',

src/applications/daemon/controller/PhabricatorDaemonConsoleController.php

@@ -81,7 +81,7 @@ public function processRequest() {
         $task->getLeaseOwner(),
         $task->getLeaseExpires() - time(),
         $task->getFailureCount(),
-        phutil_render_tag(
+        phutil_tag(
           'a',
           array(
             'href' => '/daemon/task/'.$task->getID().'/',

src/applications/daemon/view/PhabricatorDaemonLogListView.php

@@ -81,7 +81,7 @@ public function render() {
         $log->getPID(),
         phabricator_date($epoch, $this->user),
         phabricator_time($epoch, $this->user),
-        phutil_render_tag(
+        phutil_tag(
           'a',
           array(
             'href' => '/daemon/log/'.$log->getID().'/',

src/applications/differential/controller/DifferentialDiffCreateController.php

@@ -30,7 +30,7 @@ public function processRequest() {
     $form = new AphrontFormView();
     $arcanist_href = PhabricatorEnv::getDoclink(
       'article/Arcanist_User_Guide.html');
-    $arcanist_link = phutil_render_tag(
+    $arcanist_link = phutil_tag(
       'a',
       array(
         'href' => $arcanist_href,

src/applications/differential/controller/DifferentialRevisionViewController.php

@@ -184,7 +184,7 @@ public function processRequest() {
         '<p>'.pht('This diff is very large and affects %d files. Load '.
         'each file individually. ', $count).
         "<strong>".
-          phutil_render_tag(
+          phutil_tag(
             'a',
             array(
               'href' => $request_uri

src/applications/differential/view/DifferentialChangesetFileTreeSideNavBuilder.php

@@ -90,7 +90,7 @@ public function build(array $changesets) {
         $icon = 'phabricator-filetree-icon-dir';
       }
 
-      $icon = phutil_render_tag(
+      $icon = phutil_tag(
         'span',
         array(
           'class' => 'phabricator-filetree-icon '.$icon,