Skip to content

Commit e98333c

Browse files
Bug 920377 part.25 Get rid of nsUIEvent r=roc
1 parent 255381c commit e98333c

File tree

9 files changed

+20
-17
lines changed

9 files changed

+20
-17
lines changed

content/base/src/Element.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2228,8 +2228,8 @@ Element::PostHandleEventForLinks(nsEventChainPostVisitor& aVisitor)
22282228
if (shell) {
22292229
// single-click
22302230
nsEventStatus status = nsEventStatus_eIgnore;
2231-
nsUIEvent actEvent(aVisitor.mEvent->mFlags.mIsTrusted,
2232-
NS_UI_ACTIVATE, 1);
2231+
InternalUIEvent actEvent(aVisitor.mEvent->mFlags.mIsTrusted,
2232+
NS_UI_ACTIVATE, 1);
22332233

22342234
rv = shell->HandleDOMEventWithTarget(this, &actEvent, &status);
22352235
if (NS_SUCCEEDED(rv)) {

content/events/src/nsDOMEvent.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -680,8 +680,9 @@ nsDOMEvent::DuplicatePrivateData()
680680
}
681681
case NS_UI_EVENT:
682682
{
683-
nsUIEvent* oldUIEvent = static_cast<nsUIEvent*>(mEvent);
684-
nsUIEvent* uiEvent = new nsUIEvent(false, msg, oldUIEvent->detail);
683+
InternalUIEvent* oldUIEvent = static_cast<InternalUIEvent*>(mEvent);
684+
InternalUIEvent* uiEvent =
685+
new InternalUIEvent(false, msg, oldUIEvent->detail);
685686
uiEvent->AssignUIEventData(*oldUIEvent, true);
686687
newEvent = uiEvent;
687688
break;
@@ -697,8 +698,8 @@ nsDOMEvent::DuplicatePrivateData()
697698
}
698699
case NS_SMIL_TIME_EVENT:
699700
{
700-
nsUIEvent* oldUIEvent = static_cast<nsUIEvent*>(mEvent);
701-
nsUIEvent* uiEvent = new nsUIEvent(false, msg, 0);
701+
InternalUIEvent* oldUIEvent = static_cast<InternalUIEvent*>(mEvent);
702+
InternalUIEvent* uiEvent = new InternalUIEvent(false, msg, 0);
702703
uiEvent->eventStructType = NS_SMIL_TIME_EVENT;
703704
uiEvent->AssignUIEventData(*oldUIEvent, true);
704705
newEvent = uiEvent;

content/events/src/nsDOMUIEvent.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,8 @@ using namespace mozilla;
2424

2525
nsDOMUIEvent::nsDOMUIEvent(mozilla::dom::EventTarget* aOwner,
2626
nsPresContext* aPresContext, nsGUIEvent* aEvent)
27-
: nsDOMEvent(aOwner, aPresContext, aEvent ?
28-
static_cast<nsEvent *>(aEvent) :
29-
static_cast<nsEvent *>(new nsUIEvent(false, 0, 0)))
27+
: nsDOMEvent(aOwner, aPresContext,
28+
aEvent ? aEvent : new InternalUIEvent(false, 0, 0))
3029
, mClientPoint(0, 0), mLayerPoint(0, 0), mPagePoint(0, 0), mMovementPoint(0, 0)
3130
, mIsPointerLocked(nsEventStateManager::sIsPointerLocked)
3231
, mLastClientPoint(nsEventStateManager::sLastClientPoint)
@@ -45,7 +44,7 @@ nsDOMUIEvent::nsDOMUIEvent(mozilla::dom::EventTarget* aOwner,
4544
{
4645
case NS_UI_EVENT:
4746
{
48-
nsUIEvent *event = static_cast<nsUIEvent*>(mEvent);
47+
InternalUIEvent *event = static_cast<InternalUIEvent*>(mEvent);
4948
mDetail = event->detail;
5049
break;
5150
}

content/html/content/src/HTMLButtonElement.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,8 @@ HTMLButtonElement::PostHandleEvent(nsEventChainPostVisitor& aVisitor)
227227

228228
if (aVisitor.mEventStatus != nsEventStatus_eConsumeNoDefault &&
229229
aVisitor.mEvent->IsLeftClickEvent()) {
230-
nsUIEvent actEvent(aVisitor.mEvent->mFlags.mIsTrusted, NS_UI_ACTIVATE, 1);
230+
InternalUIEvent actEvent(aVisitor.mEvent->mFlags.mIsTrusted,
231+
NS_UI_ACTIVATE, 1);
231232

232233
nsCOMPtr<nsIPresShell> shell = aVisitor.mPresContext->GetPresShell();
233234
if (shell) {

content/html/content/src/HTMLInputElement.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3298,7 +3298,8 @@ HTMLInputElement::PostHandleEvent(nsEventChainPostVisitor& aVisitor)
32983298
!IsSingleLineTextControl(true) &&
32993299
aVisitor.mEvent->IsLeftClickEvent() &&
33003300
!ShouldPreventDOMActivateDispatch(aVisitor.mEvent->originalTarget)) {
3301-
nsUIEvent actEvent(aVisitor.mEvent->mFlags.mIsTrusted, NS_UI_ACTIVATE, 1);
3301+
InternalUIEvent actEvent(aVisitor.mEvent->mFlags.mIsTrusted,
3302+
NS_UI_ACTIVATE, 1);
33023303

33033304
nsCOMPtr<nsIPresShell> shell = aVisitor.mPresContext->GetPresShell();
33043305
if (shell) {

content/smil/nsDOMTimeEvent.cpp

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,12 @@
88
#include "nsIInterfaceRequestorUtils.h"
99
#include "mozilla/BasicEvents.h"
1010

11+
using namespace mozilla;
12+
1113
nsDOMTimeEvent::nsDOMTimeEvent(mozilla::dom::EventTarget* aOwner,
1214
nsPresContext* aPresContext, nsEvent* aEvent)
13-
: nsDOMEvent(aOwner, aPresContext, aEvent ? aEvent : new nsUIEvent(false, 0, 0)),
15+
: nsDOMEvent(aOwner, aPresContext,
16+
aEvent ? aEvent : new InternalUIEvent(false, 0, 0)),
1417
mDetail(0)
1518
{
1619
SetIsDOMBinding();
@@ -22,7 +25,7 @@ nsDOMTimeEvent::nsDOMTimeEvent(mozilla::dom::EventTarget* aOwner,
2225
}
2326

2427
if (mEvent->eventStructType == NS_SMIL_TIME_EVENT) {
25-
nsUIEvent* event = static_cast<nsUIEvent*>(mEvent);
28+
InternalUIEvent* event = static_cast<InternalUIEvent*>(mEvent);
2629
mDetail = event->detail;
2730
}
2831

content/smil/nsSMILTimedElement.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ namespace
9292

9393
NS_IMETHOD Run()
9494
{
95-
nsUIEvent event(true, mMsg, mDetail);
95+
InternalUIEvent event(true, mMsg, mDetail);
9696
event.eventStructType = NS_SMIL_TIME_EVENT;
9797

9898
nsPresContext* context = nullptr;

widget/BasicEvents.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1026,6 +1026,5 @@ class InternalUIEvent : public WidgetGUIEvent
10261026
typedef mozilla::WidgetEvent nsEvent;
10271027
typedef mozilla::WidgetGUIEvent nsGUIEvent;
10281028
typedef mozilla::WidgetInputEvent nsInputEvent;
1029-
typedef mozilla::InternalUIEvent nsUIEvent;
10301029

10311030
#endif // mozilla_BasicEvents_h__

widget/EventForwards.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,6 @@ class InternalMutationEvent;
106106
typedef mozilla::WidgetEvent nsEvent;
107107
typedef mozilla::WidgetGUIEvent nsGUIEvent;
108108
typedef mozilla::WidgetInputEvent nsInputEvent;
109-
typedef mozilla::InternalUIEvent nsUIEvent;
110109
typedef mozilla::WidgetMouseEventBase nsMouseEvent_base;
111110
typedef mozilla::WidgetMouseEvent nsMouseEvent;
112111
typedef mozilla::WidgetDragEvent nsDragEvent;

0 commit comments

Comments
 (0)