Rename "beta" to "prototype" and document support policy

Summary:
Fixes T6084. Changes:

  - Rename `phabricator.show-beta-applications` to `phabricator.show-prototypes`, to reinforce that these include early-development applications.
  - Migrate the config setting.
  - Add an explicit "no support" banner to the config page.
  - Rename "Beta" to "Prototype" in the UI.
  - Use "bomb" icon instead of "half star" icon.
  - Document prototype applications in more detail.
  - Explicitly document that we do not support these applications.

Test Plan:
  - Ran migration.
  - Resolved "obsolete config" issue.
  - Viewed config setting.
  - Browsed prototypes in Applications app.
  - Viewed documentation.

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: epriestley, hach-que

Maniphest Tasks: T6084

Differential Revision: https://secure.phabricator.com/D10493

Author: epriestley

conf/default.conf.php

@@ -630,9 +630,6 @@
   // be enabled in production.
   'phabricator.developer-mode' => false,
 
-  // Should Phabricator show beta applications on the homepage
-  'phabricator.show-beta-applications' => false,
-
   // Contains a list of uninstalled applications
   'phabricator.uninstalled-applications' => array(),
 

resources/celerity/map.php

@@ -7,7 +7,7 @@
  */
 return array(
   'names' => array(
-    'core.pkg.css' => 'f4235a32',
+    'core.pkg.css' => '3317a3ad',
     'core.pkg.js' => 'cbdbd552',
     'darkconsole.pkg.js' => 'df001cab',
     'differential.pkg.css' => '36884139',
@@ -38,7 +38,7 @@
     'rsrc/css/application/auth/auth.css' => '1e655982',
     'rsrc/css/application/base/main-menu-view.css' => 'aceca0e9',
     'rsrc/css/application/base/notification-menu.css' => '6aa0a74b',
-    'rsrc/css/application/base/phabricator-application-launch-view.css' => '8b7e271d',
+    'rsrc/css/application/base/phabricator-application-launch-view.css' => '5d71008f',
     'rsrc/css/application/base/standard-page-view.css' => 'dd860661',
     'rsrc/css/application/chatlog/chatlog.css' => '852140ff',
     'rsrc/css/application/config/config-options.css' => '7fedf08b',
@@ -705,7 +705,7 @@
     'path-typeahead' => 'f7fc67ec',
     'people-profile-css' => '5402f7a5',
     'phabricator-action-list-view-css' => '9ee9910a',
-    'phabricator-application-launch-view-css' => '8b7e271d',
+    'phabricator-application-launch-view-css' => '5d71008f',
     'phabricator-busy' => '6453c869',
     'phabricator-chatlog-css' => '852140ff',
     'phabricator-content-source-view-css' => '4b8b05d4',

resources/sql/autopatches/20140914.betaproto.php

@@ -0,0 +1,24 @@
+<?php
+
+$old_key = 'phabricator.show-beta-applications';
+$new_key = 'phabricator.show-prototypes';
+
+echo "Migrating '{$old_key}' to '{$new_key}'...\n";
+
+if (PhabricatorEnv::getEnvConfig($new_key)) {
+  echo "Skipping migration, new data is already set.\n";
+  return;
+}
+
+$old = PhabricatorEnv::getEnvConfigIfExists($old_key);
+if (!$old) {
+  echo "Skipping migration, old data does not exist.\n";
+  return;
+}
+
+PhabricatorConfigEntry::loadConfigEntry($new_key)
+  ->setIsDeleted(0)
+  ->setValue($old)
+  ->save();
+
+echo "Done.\n";

src/applications/base/PhabricatorApplication.php

@@ -53,8 +53,8 @@ public function isInstalled() {
       return true;
     }
 
-    $beta = PhabricatorEnv::getEnvConfig('phabricator.show-beta-applications');
-    if (!$beta && $this->isBeta()) {
+    $prototypes = PhabricatorEnv::getEnvConfig('phabricator.show-prototypes');
+    if (!$prototypes && $this->isPrototype()) {
       return false;
     }
 
@@ -65,7 +65,7 @@ public function isInstalled() {
   }
 
 
-  public function isBeta() {
+  public function isPrototype() {
     return false;
   }
 

src/applications/calendar/application/PhabricatorCalendarApplication.php

@@ -28,7 +28,7 @@ public function getTitleGlyph() {
     return "\xE2\x8C\xA8";
   }
 
-  public function isBeta() {
+  public function isPrototype() {
     return true;
   }
 

src/applications/chatlog/application/PhabricatorChatLogApplication.php

@@ -18,7 +18,7 @@ public function getIconName() {
     return 'chatlog';
   }
 
-  public function isBeta() {
+  public function isPrototype() {
     return true;
   }
 

src/applications/config/check/PhabricatorSetupCheckExtraConfig.php

@@ -190,6 +190,10 @@ public static function getAncientConfig() {
       'differential.show-host-field' => $differential_field_reason,
       'differential.show-test-plan-field' => $differential_field_reason,
       'differential.field-selector' => $differential_field_reason,
+      'phabricator.show-beta-applications' => pht(
+        'This option has been renamed to `phabricator.show-prototypes` '.
+        'to emphasize the unfinished nature of many prototype applications. '.
+        'Your existing setting has been migrated.'),
     );
 
     return $ancient_config;

src/applications/config/option/PhabricatorCoreConfigOptions.php

@@ -24,6 +24,10 @@ public function getOptions() {
 
     $path = getenv('PATH');
 
+    $proto_doc_href = PhabricatorEnv::getDoclink(
+      'User Guide: Prototype Applications');
+    $proto_doc_name = pht('User Guide: Prototype Applications');
+
     return array(
       $this->newOption('phabricator.base-uri', 'string', null)
         ->setLocked(true)
@@ -86,25 +90,33 @@ public function getOptions() {
             'Phabricator instances are running on both domains, this will '.
             'create a collision preventing you from logging in.'))
         ->addExample('dev', pht('Prefix cookie with "dev"')),
-      $this->newOption('phabricator.show-beta-applications', 'bool', false)
+      $this->newOption('phabricator.show-prototypes', 'bool', false)
         ->setBoolOptions(
           array(
-            pht('Install Beta Applications'),
-            pht('Uninstall Beta Applications')
+            pht('Enable Prototypes'),
+            pht('Disable Prototypes')
           ))
         ->setSummary(
           pht(
             'Install applications which are still under development.'))
         ->setDescription(
           pht(
-            "Phabricator includes 'Beta' applications which are in an early ".
-            "stage of development. They range from very rough prototypes to ".
-            "relatively complete (but unpolished) applications.\n\n".
-            "By default, Beta applications are not installed. You can enable ".
-            "this option to install them if you're interested in previewing ".
-            "upcoming features.\n\n".
-            "After enabling Beta applications, you can selectively uninstall ".
-            "them (like normal applications).")),
+            "IMPORTANT: The upstream does not provide support for prototype ".
+            "applications.".
+            "\n\n".
+            "Phabricator includes prototype applications which are in an ".
+            "**early stage of development**. By default, prototype ".
+            "applications are not installed, because are often not yet ".
+            "developed enough to be generally usable. You can enable ".
+            "this option to install them if you're developing Phabricator ".
+            "or are interested in previewing upcoming features.".
+            "\n\n".
+            "To learn more about prototypes, see [[ %s | %s ]].".
+            "\n\n".
+            "After enabling prototypes, you can selectively uninstall them ".
+            "(like normal applications).",
+            $proto_doc_href,
+            $proto_doc_name)),
       $this->newOption('phabricator.serious-business', 'bool', false)
         ->setBoolOptions(
           array(

src/applications/diffusion/controller/DiffusionRepositoryNewController.php

@@ -47,8 +47,7 @@ public function processRequest() {
             array(
               pht(
                 'Create a new, empty repository which Phabricator will host. '.
-                'For instructions on configuring repository hosting, see %s. '.
-                'This feature is new and in beta!',
+                'For instructions on configuring repository hosting, see %s.',
                 $doc_link),
             ))
           ->addButton(

src/applications/drydock/application/PhabricatorDrydockApplication.php

@@ -30,7 +30,7 @@ public function getApplicationGroup() {
     return self::GROUP_UTILITIES;
   }
 
-  public function isBeta() {
+  public function isPrototype() {
     return true;
   }
 

src/applications/fact/application/PhabricatorFactApplication.php

@@ -22,7 +22,7 @@ public function getApplicationGroup() {
     return self::GROUP_UTILITIES;
   }
 
-  public function isBeta() {
+  public function isPrototype() {
     return true;
   }
 

src/applications/fund/application/PhabricatorFundApplication.php

@@ -26,7 +26,7 @@ public function getApplicationGroup() {
     return self::GROUP_UTILITIES;
   }
 
-  public function isBeta() {
+  public function isPrototype() {
     return true;
   }
 

src/applications/harbormaster/application/PhabricatorHarbormasterApplication.php

@@ -36,7 +36,7 @@ public function getEventListeners() {
     );
   }
 
-  public function isBeta() {
+  public function isPrototype() {
     return true;
   }
 

src/applications/meta/controller/PhabricatorApplicationDetailViewController.php

@@ -77,10 +77,22 @@ private function buildPropertyView(
         phutil_tag('em', array(), $application->getFlavorText()));
     }
 
-    if ($application->isBeta()) {
+    if ($application->isPrototype()) {
+      $proto_href = PhabricatorEnv::getDoclink(
+        'User Guide: Prototype Applications');
+      $learn_more = phutil_tag(
+        'a',
+        array(
+          'href' => $proto_href,
+          'target' => '_blank',
+        ),
+        pht('Learn More'));
+
       $properties->addProperty(
-        pht('Release'),
-        pht('Beta'));
+        pht('Prototype'),
+        pht(
+          'This application is a prototype. %s',
+          $learn_more));
     }
 
     $overview = $application->getOverview();
@@ -160,9 +172,9 @@ private function buildActionView(
           ->setHref(
              $this->getApplicationURI(get_class($selected).'/install/'));
 
-        $beta_enabled = PhabricatorEnv::getEnvConfig(
-          'phabricator.show-beta-applications');
-        if ($selected->isBeta() && !$beta_enabled) {
+        $prototypes_enabled = PhabricatorEnv::getEnvConfig(
+          'phabricator.show-prototypes');
+        if ($selected->isPrototype() && !$prototypes_enabled) {
           $action->setDisabled(true);
         }
 

src/applications/meta/controller/PhabricatorApplicationUninstallController.php

@@ -27,21 +27,21 @@ public function processRequest() {
 
     $view_uri = $this->getApplicationURI('view/'.$this->application);
 
-    $beta_enabled = PhabricatorEnv::getEnvConfig(
-      'phabricator.show-beta-applications');
+    $prototypes_enabled = PhabricatorEnv::getEnvConfig(
+      'phabricator.show-prototypes');
 
     $dialog = id(new AphrontDialogView())
                ->setUser($user)
                ->addCancelButton($view_uri);
 
-    if ($selected->isBeta() && !$beta_enabled) {
+    if ($selected->isPrototype() && !$prototypes_enabled) {
       $dialog
-        ->setTitle(pht('Beta Applications Not Enabled'))
+        ->setTitle(pht('Prototypes Not Enabled'))
         ->appendChild(
           pht(
-            'To manage beta applications, enable them by setting %s in your '.
+            'To manage prototypes, enable them by setting %s in your '.
             'Phabricator configuration.',
-            phutil_tag('tt', array(), 'phabricator.show-beta-applications')));
+            phutil_tag('tt', array(), 'phabricator.show-prototypes')));
       return id(new AphrontDialogResponse())->setDialog($dialog);
     }
 

src/applications/meta/query/PhabricatorAppSearchEngine.php

@@ -24,8 +24,8 @@ public function buildSavedQueryFromRequest(AphrontRequest $request) {
       'installed',
       $this->readBoolFromRequest($request, 'installed'));
     $saved->setParameter(
-      'beta',
-      $this->readBoolFromRequest($request, 'beta'));
+      'prototypes',
+      $this->readBoolFromRequest($request, 'prototypes'));
     $saved->setParameter(
       'firstParty',
       $this->readBoolFromRequest($request, 'firstParty'));
@@ -51,9 +51,16 @@ public function buildQueryFromSavedQuery(PhabricatorSavedQuery $saved) {
       $query->withInstalled($installed);
     }
 
-    $beta = $saved->getParameter('beta');
-    if ($beta !== null) {
-      $query->withBeta($beta);
+    $prototypes = $saved->getParameter('prototypes');
+
+    if ($prototypes === null) {
+      // NOTE: This is the old name of the 'prototypes' option, see T6084.
+      $prototypes = $saved->getParameter('beta');
+      $saved->setParameter('prototypes', $prototypes);
+    }
+
+    if ($prototypes !== null) {
+      $query->withPrototypes($prototypes);
     }
 
     $first_party = $saved->getParameter('firstParty');
@@ -92,13 +99,13 @@ public function buildSearchForm(
             )))
       ->appendChild(
         id(new AphrontFormSelectControl())
-          ->setLabel(pht('Beta'))
-          ->setName('beta')
-          ->setValue($this->getBoolFromQuery($saved, 'beta'))
+          ->setLabel(pht('Prototypes'))
+          ->setName('prototypes')
+          ->setValue($this->getBoolFromQuery($saved, 'prototypes'))
           ->setOptions(
             array(
               '' => pht('Show All Applications'),
-              'true' => pht('Show Beta Applications'),
+              'true' => pht('Show Prototype Applications'),
               'false' => pht('Show Released Applications'),
             )))
       ->appendChild(
@@ -229,8 +236,8 @@ protected function renderResultList(
           $item->addIcon('fa-times', pht('Uninstalled'));
         }
 
-        if ($application->isBeta()) {
-          $item->addIcon('fa-star-half-o grey', pht('Beta'));
+        if ($application->isPrototype()) {
+          $item->addIcon('fa-bomb grey', pht('Prototype'));
         }
 
         if (!$application->isFirstParty()) {

src/applications/meta/query/PhabricatorApplicationQuery.php

@@ -4,7 +4,7 @@ final class PhabricatorApplicationQuery
   extends PhabricatorCursorPagedPolicyAwareQuery {
 
   private $installed;
-  private $beta;
+  private $prototypes;
   private $firstParty;
   private $nameContains;
   private $unlisted;
@@ -27,8 +27,8 @@ public function withInstalled($installed) {
     return $this;
   }
 
-  public function withBeta($beta) {
-    $this->beta = $beta;
+  public function withPrototypes($prototypes) {
+    $this->prototypes = $prototypes;
     return $this;
   }
 
@@ -99,9 +99,9 @@ public function loadPage() {
       }
     }
 
-    if ($this->beta !== null) {
+    if ($this->prototypes !== null) {
       foreach ($apps as $key => $app) {
-        if ($app->isBeta() != $this->beta) {
+        if ($app->isPrototype() != $this->prototypes) {
           unset($apps[$key]);
         }
       }

src/applications/meta/view/PhabricatorApplicationLaunchView.php

@@ -43,16 +43,6 @@ protected function getTagContent() {
         ),
         $application->getName());
 
-      if ($application->isBeta()) {
-        $content[] = javelin_tag(
-          'span',
-          array(
-            'aural' => false,
-            'class' => 'phabricator-application-beta',
-          ),
-          "\xCE\xB2");
-      }
-
       $content[] = phutil_tag(
         'span',
         array(

src/applications/nuance/application/PhabricatorNuanceApplication.php

@@ -14,7 +14,7 @@ public function getTitleGlyph() {
     return "\xE2\x98\x8E";
   }
 
-  public function isBeta() {
+  public function isPrototype() {
     return true;
   }