Port Differential mail features forward to transactions

Summary:
Ref T2222. Brings the major mail features (affected files, patches) forward.

This drops some of the minor integrations which just show object state (like "Maniphest Tasks") since I think they're not very important. I'll put them back if users miss them.

Test Plan: Sent mail with inline/attached patches.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D8459

Author: epriestley

src/__phutil_library_map__.php

@@ -335,7 +335,6 @@
     'DifferentialBlameRevisionFieldSpecification' => 'applications/differential/field/specification/DifferentialBlameRevisionFieldSpecification.php',
     'DifferentialBranchField' => 'applications/differential/customfield/DifferentialBranchField.php',
     'DifferentialBranchFieldSpecification' => 'applications/differential/field/specification/DifferentialBranchFieldSpecification.php',
-    'DifferentialCCWelcomeMail' => 'applications/differential/mail/DifferentialCCWelcomeMail.php',
     'DifferentialCCsFieldSpecification' => 'applications/differential/field/specification/DifferentialCCsFieldSpecification.php',
     'DifferentialCapabilityDefaultView' => 'applications/differential/capability/DifferentialCapabilityDefaultView.php',
     'DifferentialChangeType' => 'applications/differential/constants/DifferentialChangeType.php',
@@ -382,7 +381,6 @@
     'DifferentialDependsOnField' => 'applications/differential/customfield/DifferentialDependsOnField.php',
     'DifferentialDependsOnFieldSpecification' => 'applications/differential/field/specification/DifferentialDependsOnFieldSpecification.php',
     'DifferentialDiff' => 'applications/differential/storage/DifferentialDiff.php',
-    'DifferentialDiffContentMail' => 'applications/differential/mail/DifferentialDiffContentMail.php',
     'DifferentialDiffCreateController' => 'applications/differential/controller/DifferentialDiffCreateController.php',
     'DifferentialDiffProperty' => 'applications/differential/storage/DifferentialDiffProperty.php',
     'DifferentialDiffQuery' => 'applications/differential/query/DifferentialDiffQuery.php',
@@ -436,7 +434,6 @@
     'DifferentialMailPhase' => 'applications/differential/constants/DifferentialMailPhase.php',
     'DifferentialManiphestTasksField' => 'applications/differential/customfield/DifferentialManiphestTasksField.php',
     'DifferentialManiphestTasksFieldSpecification' => 'applications/differential/field/specification/DifferentialManiphestTasksFieldSpecification.php',
-    'DifferentialNewDiffMail' => 'applications/differential/mail/DifferentialNewDiffMail.php',
     'DifferentialPHIDTypeDiff' => 'applications/differential/phid/DifferentialPHIDTypeDiff.php',
     'DifferentialPHIDTypeRevision' => 'applications/differential/phid/DifferentialPHIDTypeRevision.php',
     'DifferentialParseCacheGarbageCollector' => 'applications/differential/garbagecollector/DifferentialParseCacheGarbageCollector.php',
@@ -456,7 +453,6 @@
     'DifferentialResultsTableView' => 'applications/differential/view/DifferentialResultsTableView.php',
     'DifferentialRevertPlanField' => 'applications/differential/customfield/DifferentialRevertPlanField.php',
     'DifferentialRevertPlanFieldSpecification' => 'applications/differential/field/specification/DifferentialRevertPlanFieldSpecification.php',
-    'DifferentialReviewRequestMail' => 'applications/differential/mail/DifferentialReviewRequestMail.php',
     'DifferentialReviewedByField' => 'applications/differential/customfield/DifferentialReviewedByField.php',
     'DifferentialReviewedByFieldSpecification' => 'applications/differential/field/specification/DifferentialReviewedByFieldSpecification.php',
     'DifferentialReviewer' => 'applications/differential/storage/DifferentialReviewer.php',
@@ -2910,7 +2906,6 @@
     'DifferentialBlameRevisionFieldSpecification' => 'DifferentialFieldSpecification',
     'DifferentialBranchField' => 'DifferentialCustomField',
     'DifferentialBranchFieldSpecification' => 'DifferentialFieldSpecification',
-    'DifferentialCCWelcomeMail' => 'DifferentialReviewRequestMail',
     'DifferentialCCsFieldSpecification' => 'DifferentialFieldSpecification',
     'DifferentialCapabilityDefaultView' => 'PhabricatorPolicyCapability',
     'DifferentialChangeset' => 'DifferentialDAO',
@@ -2957,7 +2952,6 @@
       1 => 'PhabricatorPolicyInterface',
       2 => 'HarbormasterBuildableInterface',
     ),
-    'DifferentialDiffContentMail' => 'DifferentialMail',
     'DifferentialDiffCreateController' => 'DifferentialController',
     'DifferentialDiffProperty' => 'DifferentialDAO',
     'DifferentialDiffQuery' => 'PhabricatorCursorPagedPolicyAwareQuery',
@@ -3004,7 +2998,6 @@
     'DifferentialMail' => 'PhabricatorMail',
     'DifferentialManiphestTasksField' => 'DifferentialCoreCustomField',
     'DifferentialManiphestTasksFieldSpecification' => 'DifferentialFieldSpecification',
-    'DifferentialNewDiffMail' => 'DifferentialReviewRequestMail',
     'DifferentialPHIDTypeDiff' => 'PhabricatorPHIDType',
     'DifferentialPHIDTypeRevision' => 'PhabricatorPHIDType',
     'DifferentialParseCacheGarbageCollector' => 'PhabricatorGarbageCollector',
@@ -3023,7 +3016,6 @@
     'DifferentialResultsTableView' => 'AphrontView',
     'DifferentialRevertPlanField' => 'DifferentialStoredCustomField',
     'DifferentialRevertPlanFieldSpecification' => 'DifferentialFieldSpecification',
-    'DifferentialReviewRequestMail' => 'DifferentialMail',
     'DifferentialReviewedByField' => 'DifferentialCoreCustomField',
     'DifferentialReviewedByFieldSpecification' => 'DifferentialFieldSpecification',
     'DifferentialReviewersField' => 'DifferentialCoreCustomField',

src/applications/differential/editor/DifferentialTransactionEditor.php

@@ -1019,6 +1019,46 @@ protected function buildMailBody(
       pht('REVISION DETAIL'),
       PhabricatorEnv::getProductionURI('/D'.$object->getID()));
 
+    $update_xaction = null;
+    foreach ($xactions as $xaction) {
+      switch ($xaction->getTransactionType()) {
+        case DifferentialTransaction::TYPE_UPDATE:
+          $update_xaction = $xaction;
+          break;
+      }
+    }
+
+    if ($update_xaction) {
+      $diff = $this->loadDiff($update_xaction->getNewValue(), true);
+
+      $body->addTextSection(
+        pht('AFFECTED FILES'),
+        $this->renderAffectedFilesForMail($diff));
+
+      $config_key_inline = 'metamta.differential.inline-patches';
+      $config_inline = PhabricatorEnv::getEnvConfig($config_key_inline);
+
+      $config_key_attach = 'metamta.differential.attach-patches';
+      $config_attach = PhabricatorEnv::getEnvConfig($config_key_attach);
+
+      if ($config_inline || $config_attach) {
+        $patch = $this->renderPatchForMail($diff);
+        $lines = count(phutil_split_lines($patch));
+
+        if ($config_inline && ($lines <= $config_inline)) {
+          $body->addTextSection(
+            pht('CHANGE DETAILS'),
+            $patch);
+        }
+
+        if ($config_attach) {
+          $name = pht('D%s.%s.patch', $object->getID(), $diff->getID());
+          $mime_type = 'text/x-patch; charset=utf-8';
+          $body->addAttachment(
+            new PhabricatorMetaMTAAttachment($patch, $name, $mime_type));
+        }
+      }
+    }
 
     return $body;
   }
@@ -1491,4 +1531,30 @@ private function updateRevisionHashTable(
     }
   }
 
+  private function renderAffectedFilesForMail(DifferentialDiff $diff) {
+    $changesets = $diff->getChangesets();
+
+    $filenames = mpull($changesets, 'getDisplayFilename');
+    sort($filenames);
+
+    $count = count($filenames);
+    $max = 250;
+    if ($count > $max) {
+      $filenames = array_slice($filenames, 0, $max);
+      $filenames[] = pht('(%d more files...)', ($count - $max));
+    }
+
+    return implode("\n", $filenames);
+  }
+
+  private function renderPatchForMail(DifferentialDiff $diff) {
+    $format = PhabricatorEnv::getEnvConfig('metamta.differential.patch-format');
+
+    return id(new DifferentialRawDiffRenderer())
+      ->setViewer($this->getActor())
+      ->setFormat($format)
+      ->setChangesets($diff->getChangesets())
+      ->buildPatch();
+  }
+
 }

src/applications/differential/field/specification/DifferentialArcanistProjectFieldSpecification.php

@@ -35,18 +35,4 @@ private function getArcanistProjectPHID() {
     return $diff->getArcanistProjectPHID();
   }
 
-  public function renderValueForMail($phase) {
-    $diff = $this->getRevision()->loadActiveDiff();
-    if ($diff) {
-      $phid = $diff->getArcanistProjectPHID();
-      if ($phid) {
-        $handle = id(new PhabricatorHandleQuery())
-          ->setViewer($this->getUser())
-          ->withPHIDs(array($phid))
-          ->executeOne();
-        return "ARCANIST PROJECT\n  ".$handle->getName();
-      }
-    }
-  }
-
 }

src/applications/differential/field/specification/DifferentialBranchFieldSpecification.php

@@ -31,16 +31,4 @@ public function renderValueForRevisionView() {
     return $this->getBranchOrBookmarkDescription($diff);
   }
 
-  public function renderValueForMail($phase) {
-    $diff = $this->getRevision()->loadActiveDiff();
-    if ($diff) {
-      $description = $this->getBranchOrBookmarkDescription($diff);
-      if ($description) {
-        return "BRANCH\n  {$description}";
-      }
-    }
-
-    return null;
-  }
-
 }

src/applications/differential/field/specification/DifferentialCommitsFieldSpecification.php

@@ -34,30 +34,4 @@ private function getCommitPHIDs() {
     return $revision->getCommitPHIDs();
   }
 
-  public function renderValueForMail($phase) {
-    $revision = $this->getRevision();
-
-    if ($revision->getStatus() != ArcanistDifferentialRevisionStatus::CLOSED) {
-      return null;
-    }
-
-    $phids = $revision->loadCommitPHIDs();
-    if (!$phids) {
-      return null;
-    }
-
-    $body = array();
-    $handles = id(new PhabricatorHandleQuery())
-      ->setViewer($this->getUser())
-      ->withPHIDs($phids)
-      ->execute();
-    $body[] = pht('COMMIT(S)', count($handles));
-
-    foreach ($handles as $handle) {
-      $body[] = '  '.PhabricatorEnv::getProductionURI($handle->getURI());
-    }
-
-    return implode("\n", $body);
-  }
-
 }

src/applications/differential/field/specification/DifferentialFieldSpecification.php

@@ -385,23 +385,6 @@ public function renderValueForDiffView() {
   }
 
 
-/* -(  Extending the E-mail Interface  )------------------------------------- */
-
-
-  /**
-   * Return plain text to render in e-mail messages. The text may span
-   * multiple lines.
-   *
-   * @return int One of DifferentialMailPhase constants.
-   * @return string|null Plain text, or null for no message.
-   *
-   * @task mail
-   */
-  public function renderValueForMail($phase) {
-    return null;
-  }
-
-
 /* -(  Extending the Conduit Interface  )------------------------------------ */
 
 

src/applications/differential/field/specification/DifferentialManiphestTasksFieldSpecification.php

@@ -127,32 +127,4 @@ public function parseValueFromCommitMessage($value) {
     return $task_phids;
   }
 
-  public function renderValueForMail($phase) {
-    if ($phase == DifferentialMailPhase::COMMENT) {
-      return null;
-    }
-
-    if (!$this->maniphestTasks) {
-      return null;
-    }
-
-    $handles = id(new PhabricatorHandleQuery())
-      ->setViewer($this->getUser())
-      ->withPHIDs($this->maniphestTasks)
-      ->execute();
-    $body = array();
-    $body[] = 'MANIPHEST TASKS';
-    foreach ($handles as $handle) {
-      $body[] = '  '.PhabricatorEnv::getProductionURI($handle->getURI());
-    }
-    return implode("\n", $body);
-  }
-
-  public function getCommitMessageTips() {
-    return array(
-      'Use "Fixes T123" in your summary to mark that the current '.
-      'revision completes a given task.'
-      );
-  }
-
 }

src/applications/differential/field/specification/DifferentialReviewersFieldSpecification.php

@@ -173,25 +173,4 @@ public function getRequiredHandlePHIDsForRevisionList(
     return $revision->getReviewers();
   }
 
-  public function renderValueForMail($phase) {
-    if ($phase == DifferentialMailPhase::COMMENT) {
-      return null;
-    }
-
-    if (!$this->reviewers) {
-      return null;
-    }
-
-    $handles = id(new PhabricatorHandleQuery())
-      ->setViewer($this->getUser())
-      ->withPHIDs($this->reviewers)
-      ->execute();
-    $handles = array_select_keys(
-      $handles,
-      array($this->getRevision()->getPrimaryReviewer())) + $handles;
-
-    $names = mpull($handles, 'getObjectName');
-    return 'Reviewers: '.implode(', ', $names);
-  }
-
 }

src/applications/differential/field/specification/DifferentialRevisionIDFieldSpecification.php

@@ -96,25 +96,4 @@ public function renderValueForRevisionList(DifferentialRevision $revision) {
     return 'D'.$revision->getID();
   }
 
-  public function renderValueForMail($phase) {
-    $body = array();
-    $body[] = 'REVISION DETAIL';
-    $body[] = '  '.PhabricatorEnv::getProductionURI('/D'.$this->id);
-
-    if ($phase == DifferentialMailPhase::UPDATE) {
-      $diffs = id(new DifferentialDiff())->loadAllWhere(
-        'revisionID = %d ORDER BY id DESC LIMIT 2',
-        $this->id);
-      if (count($diffs) == 2) {
-        list($new, $old) = array_values(mpull($diffs, 'getID'));
-        $body[] = null;
-        $body[] = 'CHANGE SINCE LAST DIFF';
-        $body[] = '  '.PhabricatorEnv::getProductionURI(
-          "/D{$this->id}?vs={$old}&id={$new}#toc");
-      }
-    }
-
-    return implode("\n", $body);
-  }
-
 }

src/applications/differential/field/specification/DifferentialSummaryFieldSpecification.php

@@ -67,18 +67,6 @@ public function parseValueFromCommitMessage($value) {
     return (string)$value;
   }
 
-  public function renderValueForMail($phase) {
-    if ($phase != DifferentialMailPhase::WELCOME) {
-      return null;
-    }
-
-    if ($this->summary == '') {
-      return null;
-    }
-
-    return $this->summary;
-  }
-
   public function shouldAddToSearchIndex() {
     return true;
   }

src/applications/differential/field/specification/DifferentialTestPlanFieldSpecification.php

@@ -91,18 +91,6 @@ public function parseValueFromCommitMessage($value) {
     return $value;
   }
 
-  public function renderValueForMail($phase) {
-    if ($phase != DifferentialMailPhase::WELCOME) {
-      return null;
-    }
-
-    if ($this->plan == '') {
-      return null;
-    }
-
-    return "TEST PLAN\n".preg_replace('/^/m', '  ', $this->plan);
-  }
-
   public function shouldAddToSearchIndex() {
     return true;
   }