drivers: misc: fix condition in gpio_ra_interrupt_unset function #91231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the condition in the gpio_ra_interrupt_unset function to use a logical OR instead of AND, since it should return if either port_num or pin is not the same as the current callback. Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
|
kartben
added
the
Trivial
| @@ -107,7 +107,7 @@ void gpio_ra_interrupt_unset(const struct device *dev, uint8_t port_num, uint8_t | |||
| const struct gpio_ra_irq_config *config = dev->config; | |||
| struct gpio_ra_irq_data *data = dev->data; | |||
|
|
|||
| if ((port_num != data->callback.port_num) && (pin != data->callback.pin)) { | |||
| if ((port_num != data->callback.port_num) || (pin != data->callback.pin)) { | |||
There was a problem hiding this comment.
I think it'd be logically easier to understand if it was written as
if (!((port_num == data->callback.port_num) && (pin == data->callback.pin))) {may be just me though... up to you
fabiobaltieri
approved these changes
Jun 10, 2025
khoa-nguyen-18
approved these changes
Jun 17, 2025
thenguyenyf
approved these changes
Jun 17, 2025
duynguyenxa
approved these changes
Jun 17, 2025
soburi
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the condition in the gpio_ra_interrupt_unset function to use a logical OR instead of AND, since it should return if either port_num or pin is not the same as the current callback.