Skip to content

drivers: clock_control: wch_rcc: remove duplicate reg write #91234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

kartben
Copy link
Contributor

@kartben kartben commented Jun 7, 2025

Removed a redundant register write to FLASH->ACTLR

Removed a redundant register write to FLASH->ACTLR

Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
Copy link

sonarqubecloud bot commented Jun 7, 2025

@kartben kartben marked this pull request as ready for review June 7, 2025 19:45
@github-actions github-actions bot added area: Clock Control size: XS A PR changing only a single line of code platform: WinChipHead labels Jun 7, 2025
Copy link
Contributor

@VynDragon VynDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@nzmichaelh nzmichaelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spotting, thanks!

@fabiobaltieri fabiobaltieri added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Jun 9, 2025
@dkalowsk
Copy link
Contributor

dkalowsk commented Jun 9, 2025

are you sure this is redundant and not something necessary for the specific code path? AKA wouldn't be the first time I've seen a need like this.

@dkalowsk
Copy link
Contributor

dkalowsk commented Jun 9, 2025

are you sure this is redundant and not something necessary for the specific code path? AKA wouldn't be the first time I've seen a need like this.

sync'd on discord, moving forward on the PR

@dkalowsk dkalowsk merged commit ec01159 into zephyrproject-rtos:main Jun 9, 2025
31 checks passed
@kartben kartben deleted the wch_rcc branch June 9, 2025 22:15
@nzmichaelh
Copy link
Contributor

Late to the party, but the extra write was a refactoring error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Clock Control platform: WinChipHead size: XS A PR changing only a single line of code Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants