drivers: dac: esp32: avoid out-of-range channel ID #91237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: DAC
github-actions
bot
requested review from
LucasTambor,
marekmatej,
martinjaeger,
raffarost,
sylvioalves,
uLipe and
wmrsouza
wmrsouza
approved these changes
Jun 9, 2025
raffarost
approved these changes
Jun 9, 2025
sylvioalves
approved these changes
Jun 9, 2025
marekmatej
approved these changes
Jun 9, 2025
I am not sure what you mean? Sorry |
"fix channel ID check" -> "Fix channel ID check" |
Fix channel ID check in dac_esp32_channel_setup as it was allowing to set up a channel with ID greater than the number of channels. Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
Sure 🤷🏼 |
|
marekmatej
approved these changes
Jun 9, 2025
martinjaeger
approved these changes
Jun 10, 2025
uLipe
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix channel ID check in dac_esp32_channel_setup as it was allowing to set up a channel with ID greater than the number of channels.