drivers: video: shell: fix the name comparison #91239
Draft
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shell was comparing a string with itself, so was never selecting anything else than the first one. Compare the input against the control name to fix it. Signed-off-by: Josuah Demangeon <me@josuah.net>
The log message was copy-pasted without modification from another function. Signed-off-by: Josuah Demangeon <me@josuah.net>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Popped out of:
The shell was copying a string, and comparing the two copies.
This lead to a bug where only the first control ID was selected regardless of what was typed.
Also, a log message cleanup.