Skip to content

drivers: led: fix LED_BRIGTHNESS_MAX typo #91245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2025
Merged

drivers: led: fix LED_BRIGTHNESS_MAX typo #91245

merged 1 commit into from
Jun 9, 2025

Conversation

@kartben
Copy link
Contributor

@kartben kartben commented Jun 7, 2025 •
edited
Loading

Renames LED_BRIGTHNESS_MAX to LED_BRIGHTNESS_MAX in led.h and all in-tree users of the macro.

@kartben kartben mentioned this pull request Jun 7, 2025
Open
15 tasks
@kartben kartben marked this pull request as ready for review June 7, 2025 21:33
@github-actions github-actions bot added Release Notes To be mentioned in the release notes area: LED Label to identify LED subsystem labels Jun 7, 2025
faxe1008
faxe1008 previously approved these changes Jun 8, 2025
View reviewed changes
Copy link
Contributor

@faxe1008 faxe1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the migration guide is not needed since the macro was introduced this release cycle?

@kartben
Copy link
Contributor Author

kartben commented Jun 8, 2025

I think the migration guide is not needed since the macro was introduced this release cycle?

Oh was it? Didn't really thought of checking. Then I'll also drop the deprecation and go for a simple rename :)

@kartben
drivers: led: fix LED_BRIGTHNESS_MAX typo
87aa338 
Renames LED_BRIGTHNESS_MAX to LED_BRIGHTNESS_MAX in led.h and all
in-tree users of the macro.

Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
@kartben kartben requested a review from fabiobaltieri June 9, 2025 06:23
fabiobaltieri
fabiobaltieri approved these changes Jun 9, 2025
View reviewed changes
Copy link
Member

@fabiobaltieri fabiobaltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

palmface

@fabiobaltieri fabiobaltieri added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Jun 9, 2025
simonguinot
simonguinot previously requested changes Jun 9, 2025
View reviewed changes
Copy link
Contributor

@simonguinot simonguinot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@simonguinot simonguinot closed this Jun 9, 2025
@simonguinot simonguinot reopened this Jun 9, 2025
@simonguinot simonguinot dismissed their stale review June 9, 2025 09:55

Preview review was due to a miss-click

@fabiobaltieri fabiobaltieri added area: Input Input Subsystem and Drivers and removed area: Input Input Subsystem and Drivers labels Jun 9, 2025
@fabiobaltieri fabiobaltieri reopened this Jun 9, 2025
@fabiobaltieri
Copy link
Member

fabiobaltieri commented Jun 9, 2025 •
edited
Loading

One more to see if the dashboard picks it up. Really GitHub, really.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dkalowsk dkalowsk merged commit f729420 into zephyrproject-rtos:main Jun 9, 2025
92 checks passed
@kartben kartben deleted the led_typo branch June 9, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabiobaltieri fabiobaltieri

@faxe1008 faxe1008

@dkalowsk dkalowsk

@simonguinot simonguinot

@danieldegrasse danieldegrasse

@Mani-Sadhasivam Mani-Sadhasivam

Assignees

@Mani-Sadhasivam Mani-Sadhasivam

@simonguinot simonguinot

Labels

area: LED Label to identify LED subsystem Release Notes To be mentioned in the release notes Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kartben @fabiobaltieri @faxe1008 @dkalowsk @simonguinot @Mani-Sadhasivam