drivers:dac:dac_ad56xx.c - Added support for selected DAC channel for Channel A and Channel B together and All channel for AD5686 #91255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: DAC
github-actions
bot
requested review from
MaureenHelm,
galak,
martinjaeger,
microbuilder,
ozersa,
ttmut and
yasinustunerg
adityaganeshcu2k
force-pushed
the
dac_ad5686
branch
from
b1fb075 to
f4740bf
Compare
github-actions
bot
requested review from
LucasTambor,
aescolar,
avisconti,
marekmatej,
raffarost,
sylvioalves,
uLipe and
wmrsouza
adityaganeshcu2k
force-pushed
the
dac_ad5686
branch
from
f4740bf to
b386306
Compare
|
martinjaeger
approved these changes
Jul 16, 2025
martinjaeger
requested changes
Jul 16, 2025
adityaganeshcu2k
force-pushed
the
dac_ad5686
branch
from
b386306 to
61e49d0
Compare
|
@martinjaeger sorry for the late reply I have fixed the commit message |
|
@adityaganesh The message body can not be empty in the commit message. See pull-request-guidelines Otherwise LGTM |
uLipe
reviewed
Aug 15, 2025
There was a problem hiding this comment.
@adityaganesh please fix the compliance check issues, happy to review it again when solved.
Added support for selecting channels A, B, both together, and all channels on the AD5686 DAC driver. This improves flexibility for multi-channel DAC applications. Signed-off-by: Aditya Ganesh <adga5133@colorado.edu>
adityaganeshcu2k
force-pushed
the
dac_ad5686
branch
from
61e49d0 to
1412b47
Compare
|
@uLipe I have fixed the compliance check issue. Let me know if something else needs to be done |
|
MaureenHelm
approved these changes
Aug 18, 2025
wmrsouza
approved these changes
Aug 18, 2025
uLipe
approved these changes
Aug 19, 2025
martinjaeger
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref :- AD5686/AD5684 datasheet Page 19 , Table 9
