Skip to content

Add Azure Language Services provider #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 31 commits into
base: develop
Choose a base branch
from

Conversation

psorensen
Copy link

@psorensen psorensen commented Aug 1, 2024

Description of the Change

This PR adds Azure Language Services as a provider and adds it to the Excerpt Generation feature.

Closes #159

How to test the Change

Testing Steps:

  1. Create new Azure resource for Language Services
  2. Enter Credentials into the Excerpt Generation feature screen
  3. Confirm valid credentials allow feature to be enabled
  4. Test 'Generate Excerpt' tag for allowed post types.

Changelog Entry

Added - Azure Language Services provider with Excerpt Generation.

Credits

Props @psorensen @cadic @jeffpaul @Sidsector9 @dkotter

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@psorensen psorensen requested review from dkotter, jeffpaul and a team as code owners August 1, 2024 18:47
@github-actions github-actions bot added this to the 3.2.0 milestone Aug 1, 2024
@github-actions github-actions bot added the needs:feedback This requires reporter feedback to better understand the request. label Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

@psorensen thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this?

@psorensen psorensen marked this pull request as draft August 1, 2024 19:18
@github-actions github-actions bot removed the needs:feedback This requires reporter feedback to better understand the request. label Aug 1, 2024
@psorensen psorensen force-pushed the feature/azure-language-service branch from 1239c7d to 55bca24 Compare August 2, 2024 13:48
@psorensen psorensen marked this pull request as ready for review August 5, 2024 20:17
@github-actions github-actions bot added the needs:feedback This requires reporter feedback to better understand the request. label Aug 5, 2024
@psorensen
Copy link
Author

@dkotter How should I handle the VIP flag for wp_remote_get usage? Should I conditionally use it if defined, or ignore this rule?

@dkotter
Copy link
Collaborator

dkotter commented Aug 5, 2024

@dkotter How should I handle the VIP flag for wp_remote_get usage? Should I conditionally use it if defined, or ignore this rule?

So we've not been consistent with this so far in the codebase. We've basically done both, where we use vip_safe_wp_remote_get if it exists (see here) and otherwise use wp_remote_get and in other places we just use wp_remote_get and add an ignore statement.

Personally I'd prefer we go with the first approach, as this is technically a VIP approved plugin so it's nice to match their standards. We have had issues though a few times with timeouts, as some of these services take a bit to return. vip_safe_wp_remote_get only allows you to set a timeout of 3 seconds so if we need higher than that here, we'll want to stick with wp_remote_get only

@psorensen psorensen force-pushed the feature/azure-language-service branch from 1bac627 to b550389 Compare August 6, 2024 00:39
@github-actions github-actions bot added needs:code-review This requires code review. and removed needs:feedback This requires reporter feedback to better understand the request. labels Aug 6, 2024
@psorensen
Copy link
Author

sounds good @dkotter - I've included a helper function to facilitate a refactor of all the existing usage of wp_remote_get

@jeffpaul jeffpaul removed request for a team and jeffpaul August 13, 2024 02:22
@jeffpaul
Copy link
Member

@psorensen is this still WIP or can this formally go through review/merge?

sksaju and others added 3 commits May 19, 2025 19:41
@github-actions github-actions bot removed the needs:refresh This requires a refreshed PR to resolve. label Jun 10, 2025
@psorensen psorensen force-pushed the feature/azure-language-service branch from 6e67146 to 2542b7f Compare June 30, 2025 20:53
…ion settings

Hide prompt and length fields when Azure Language provider is selected since it uses predefined string options for these settings.
@psorensen psorensen requested a review from Sidsector9 June 30, 2025 22:46
@psorensen psorensen force-pushed the feature/azure-language-service branch 3 times, most recently from b05cf8d to cf867a2 Compare July 1, 2025 00:03
@psorensen psorensen force-pushed the feature/azure-language-service branch from cf867a2 to 4139791 Compare July 1, 2025 00:49
@jeffpaul jeffpaul modified the milestones: Future Release, 3.7.0 Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-populate missing meta tags and descriptions
5 participants