Skip to content

Bugfix/no opener referer empty property #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

WilmanVasquez
Copy link
Contributor

@WilmanVasquez WilmanVasquez commented Jun 13, 2025

A few fixes here:

  • Noopener and Noreferer options were not pass into the items
  • Add Noopener and Noreferer a default value because when upgrading from previous umbNav version boolean values may stick(this is really odd but it doesn't hurt)
  • Change this._value ?? [] for this._value || [] because after saving the document with no items in the navigation property an empty string is saved there for this._value ?? [] returns "" but this._value || [] returns []
    onSave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant