-
Notifications
You must be signed in to change notification settings - Fork 43
feat: group and highlight components by tag name #3057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: group and highlight components by tag name #3057
Conversation
View your CI Pipeline Execution ↗ for commit 497c4a2.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAttention: Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
let timerFlag: ReturnType<typeof setTimeout> | null = null; | ||
|
||
const throttleFn = (...args: Parameters<T>) => { | ||
if (timerFlag === null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You always call the fn twice even if it has only been called once. Maybe we should add a flag to run the fn() after the timeout only if it has been called during the throttle (in an else block for instance)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove L85
it's from my code sorry :)
Related issues
🚀 Feature #2532
Use
postMessage
to play with the configs (chrome extension part is not done yet)