Skip to content

fix: adjust path replacement script to work with node 20.19.0 #3189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/12.2
Choose a base branch
from

Conversation

guillaumerochelle
Copy link
Contributor

Proposed change

Follow-up PR after it-tests breaking due to pnp infinite loop and maximum call stack exceeded

Related issues

Fixes 🐛 #3047

@guillaumerochelle guillaumerochelle requested a review from a team as a code owner May 6, 2025 14:32
Copy link

nx-cloud bot commented May 6, 2025

View your CI Pipeline Execution ↗ for commit 23f9852.

Command Status Duration Result
nx run-many --target=test-e2e ✅ Succeeded 2m 37s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded 2m 40s View ↗
nx run-many --target=build,build-swagger ✅ Succeeded 13m 17s View ↗
nx affected --target=test --collectCoverage --c... ✅ Succeeded 1m 38s View ↗
nx run ama-sdk-schematics:build-swagger ✅ Succeeded 8s View ↗
nx affected --target=lint --configuration ci ✅ Succeeded 3m 14s View ↗
nx affected --target=package-github-action ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-06 14:58:02 UTC

Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.72%. Comparing base (ae52e28) to head (23f9852).
Report is 1 commits behind head on release/12.2.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -23,7 +23,7 @@ on:
env:
NX_PARALLEL: ${{ vars.NX_PARALLEL }}
NX_TASK_TARGET_CONFIGURATION: ci
NX_SKIP_NX_CACHE: ${{ inputs.skipNxCache }}
NX_SKIP_NX_CACHE: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you need this change?

Copy link
Contributor Author

@guillaumerochelle guillaumerochelle May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous PR used the cache for the PR build and it-tests were successful.
The build on the release failed because it-tests ran without cache.

Trying to skip NX cache on the PR build to avoid merging something which won't build afterwards.
I will revert this once I find the solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants