Skip to content

fix: resolve placeholder subscription to free references #3241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/11.6
Choose a base branch
from

Conversation

ntrotner
Copy link
Contributor

@ntrotner ntrotner commented May 27, 2025

Proposed change

Before Fix: Placeholder Elements in Memory

Screenshot 2025-05-27 at 21 22 35

After Fix

Screenshot 2025-05-27 at 21 22 31

Related issues

🐛 Fix resolves #3234

@ntrotner ntrotner requested a review from a team as a code owner May 27, 2025 19:34
@kpanot kpanot linked an issue May 27, 2025 that may be closed by this pull request
Copy link

nx-cloud bot commented May 28, 2025

View your CI Pipeline Execution ↗ for commit ba798e8.

Command Status Duration Result
nx run-many --target=test-e2e ❌ Failed 1m 33s View ↗
nx run-many --target=test-int ✅ Succeeded 41m 11s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-10 14:53:23 UTC

Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.55%. Comparing base (b843f38) to head (ba798e8).

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ntrotner ntrotner force-pushed the fix/resolve-placeholder-subscription branch from 6bdea7c to 143a92e Compare May 28, 2025 04:51
kpanot
kpanot previously approved these changes May 29, 2025
@kpanot kpanot self-requested a review May 29, 2025 01:52
@ntrotner ntrotner force-pushed the fix/resolve-placeholder-subscription branch from 143a92e to ba798e8 Compare June 2, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Memory leak in PlaceholderComponent
3 participants