Skip to content

[cascading] from release/12.4.0-rc to main #3287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 23, 2025
Merged

[cascading] from release/12.4.0-rc to main #3287

merged 3 commits into from
Jun 23, 2025

Conversation

otter-cascading[bot]
Copy link
Contributor

Cascading from release/12.4.0-rc to main

This Pull Request has been generated with ❤️ by the Otter cascading tool.

cpaulve-1A and others added 3 commits June 20, 2025 11:22
@cpaulve-1A
fix: install dependencies on ng add and do first install on o3r creat…
0597c8d 
…e with legacy peer dep

This prevents npm to deduce which version to install based on the caret.

Instead, npm will rely on the one added on the package.json
@cpaulve-1A
fix: @o3r create is broken when new minor of peer dependencies are pu…
b0c39e5 
…blished (#3129)

## Proposed change

Install dependencies on ng add and do first install on o3r create with
legacy peer dep.

This prevents npm to deduce which version to install based on the caret
but to rely instead on the one on the package.json


## Related issues

<!--
Please make sure to follow the [contribution
guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md)
-->

*- No issue associated -*

<!-- * 🐛 Fix #issue -->
<!-- * 🐛 Fix resolves #issue -->
<!-- * 🚀 Feature #issue -->
<!-- * 🚀 Feature resolves #issue -->
<!-- * :octocat: Pull Request #issue -->
@otter-cascading
Merge release/12.4.0-rc into cascading/12.4.0-rc-main
5189848
@otter-cascading otter-cascading bot requested a review from a team as a code owner June 20, 2025 09:37
@otter-cascading otter-cascading bot added the cascading Cascading from previous release label Jun 20, 2025
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 20, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 5189848.

Command Status Duration Result
nx run-many --target=test-int ✅ Succeeded 38m 55s View ↗
nx run-many --target=test-e2e ✅ Succeeded 2m 36s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded <1s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 34s View ↗
nx run-many --target=prepare-publish --exclude-... ✅ Succeeded 8s View ↗
nx run-many --target=build,build-swagger ✅ Succeeded 19m 18s View ↗
nx affected --target=lint --configuration ci ✅ Succeeded 16m 10s View ↗
nx affected --target=test --collectCoverage --c... ✅ Succeeded 9m 57s View ↗
Additional runs (3) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-06-20 10:45:33 UTC

@codecov Codecov
Copy link

codecov bot commented Jun 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.72727% with 27 lines in your changes missing coverage. Please review.

Project coverage is 70.70%. Comparing base (982d2f8) to head (5189848).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
...ges/@ama-sdk/schematics/schematics/ng-add/index.ts 41.17% 10 Missing ⚠️
...ckages/@o3r/schematics/src/utility/dependencies.ts 85.24% 7 Missing and 2 partials ⚠️
...o3r/eslint-config-otter/schematics/ng-add/index.ts 22.22% 7 Missing ⚠️
...ages/@o3r/eslint-config/schematics/ng-add/index.ts 90.90% 0 Missing and 1 partial ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matthieu-crouzet matthieu-crouzet added this pull request to the merge queue Jun 23, 2025
Merged via the queue into main with commit 6ef9ba0 Jun 23, 2025
31 of 33 checks passed
@matthieu-crouzet matthieu-crouzet deleted the cascading/12.4.0-rc-main branch June 23, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieu-crouzet matthieu-crouzet matthieu-crouzet approved these changes

@fpaul-1A fpaul-1A fpaul-1A approved these changes

Assignees
No one assigned
Labels
cascading Cascading from previous release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthieu-crouzet @fpaul-1A @cpaulve-1A