Skip to content

Kraken/yomi/UI infra #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: kraken/unstructured-data-processing
Choose a base branch
from

Conversation

Joll59
Copy link

@Joll59 Joll59 commented Feb 14, 2025

Type of PR

  • Code changes

Purpose

Introduced Bicep files for Function App and App service Plan for consistent deployment

Does this introduce a breaking change? If yes, details on what can break

No!

Author pre-publish checklist

  • No PII in logs
  • Made corresponding changes to the documentation

Validation steps

  • Deployed resources in azure.

Issues Referenced

@Joll59 Joll59 linked an issue Feb 14, 2025 that may be closed by this pull request
4 tasks
@Joll59 Joll59 changed the base branch from main to kraken/unstructured-data-processing February 14, 2025 19:02
@Joll59 Joll59 force-pushed the kraken/yomi/UIInfra branch from 7efbabe to 734b6b2 Compare February 20, 2025 18:57
@Joll59 Joll59 marked this pull request as ready for review February 20, 2025 19:02
@Joll59 Joll59 requested a review from jose-perales February 20, 2025 19:03
@audols
Copy link

audols commented Feb 21, 2025

Can we also update README.md to reflect the newly added resources to this deployment?

@audols
Copy link

audols commented Feb 21, 2025

Just tried running the deployment - I'm getting a Website with given name excitation-testing already exists. error on the App Service deployment. Should be a simple fix to add an id to the name or something else to randomize it.

@audols audols self-requested a review February 21, 2025 18:18
@audols
Copy link

audols commented Feb 25, 2025

Just tried running the deployment - I'm getting a Website with given name excitation-testing already exists. error on the App Service deployment. Should be a simple fix to add an id to the name or something else to randomize it.

Same issue with Website with given name excitationfuncapp already exists.

@Joll59 Joll59 force-pushed the kraken/yomi/UIInfra branch from f1533e3 to e601bb1 Compare March 6, 2025 17:04
Joll59 added 6 commits March 7, 2025 13:15
integrate modules with main bicep

update resource references

remove unused output from appservice module

make infra changes for deployment errors

update to deploy resources into deployed infra

remove commented lines and update descriptions
update deploy/cleanup script, debug
update appinsights resource api
update for SQL role creation

address role creattion error
remove app insight variable from appservice bicep
@Joll59 Joll59 force-pushed the kraken/yomi/UIInfra branch from 6dea804 to 9639fc5 Compare March 7, 2025 18:17

az functionapp deployment source config-zip -g $RESOURCE_GROUP -n $FUNCTION_APP --src ./deploy.zip --verbose

# # Create the storage container
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can clean up all old/commented out code here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Citation Tool UI and DB Connector Deployment
2 participants