Skip to content

Update README.md #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

lukaszkozdron
Copy link

@lukaszkozdron lukaszkozdron commented Feb 23, 2025

Type of PR

  • Documentation changes
  • Code changes
  • Test changes
  • CI-CD changes
  • GitHub Template changes

Purpose

  • ...

Does this introduce a breaking change? If yes, details on what can break

Author pre-publish checklist

  • Added test to prove my fix is effective or new feature works
  • No PII in logs
  • Made corresponding changes to the documentation

Validation steps

  • ...

Issues Closed or Referenced

  • Closes #issue_number
  • References #issue_number

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the README.md file for the Microsoft Fabric utilities and improves the usage instructions.

  • The variable names for workspace and lakehouse IDs have been changed for clarity.
  • The usage message has been updated with an additional authentication method option.
  • The sample usage output now includes a line indicating the authentication method in the execution log.

Comment on lines +50 to 51
usage: upload-file-to-lakehouse.py [-h] [--upload_from {local,git}] [--auth_method {pat,oauth} source_file_path target_file_path

Copy link
Preview

Copilot AI Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usage string appears to be missing a closing bracket for the --auth_method option. Please update it to read, for example, '[--auth_method {pat,oauth}] source_file_path target_file_path' for clarity.

Suggested change
usage: upload-file-to-lakehouse.py [-h] [--upload_from {local,git}] [--auth_method {pat,oauth} source_file_path target_file_path
usage: upload-file-to-lakehouse.py [-h] [--upload_from {local,git}] [--auth_method {pat,oauth}] source_file_path target_file_path

Copilot uses AI. Check for mistakes.

@bsherwin
Copy link
Contributor

@lukaszkozdron closing this PR since it doesn't line up with current implementation. Please resubmit if possible.

@bsherwin bsherwin closed this Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants