Add ability to start lasso select within object without dragging layers #2799
+223
−174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemu
commented
Jun 30, 2025
Comment on lines
-548
to
-550
| if handle_drag_from_anchor { | ||
| if let Some((layer, point)) = shape_editor.find_nearest_point_indices(&document.network_interface, input.mouse.position, SELECTION_THRESHOLD) { | ||
| // Check that selected point is an anchor |
There was a problem hiding this comment.
didn't change almost any of this logic. The diff just seems large because I moved the pieces from the if/else chain into a match statement
|
if this change is too involved and not preferred there is a simpler change here: #2798 |
|
I tested this and didn't find any obvious regressions @Keavon 👍 |
|
@hemu could you please resolve the merge conflict? I tried but it looks like it affects the structure of an if-else statement that changed. Thanks. Also, please mark this as ready for review and comment when you've completed this. I'm marking it as a draft for now while waiting the resolution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When beginning a lasso select from within an object, currently the behavior is to drag its layers. This PR updates this behavior such that a lasso select beginning within an object will remain a lasso selection over the existing layers.
Refactor select_tool and path_tool transition drag logic to determine an "intent" up front. This made it easier to incorporate the type of logic needed in this PR where the lasso select intent has priority over others, but its logic is shared with box select which has the lowest priority so it was hard to capture this in the existing if/else chain.
Part of #2647
NOTE: This is an alternate implementation compared to this simpler change: #2798
Before
graphite_fix_start_lasso_inside_before.mp4
After
graphite_fix_start_lasso_inside_after.mp4