Add new node "Decimate" #2823
Draft
Add new node "Decimate" #2823
+188
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0HyperCube
reviewed
Jul 5, 2025
Comment on lines
+2016
to
+2022
| DocumentNode { | ||
| inputs: vec![NodeInput::network(concrete!(graphene_std::vector::VectorDataTable), 0)], | ||
| implementation: DocumentNodeImplementation::ProtoNode(ProtoNodeIdentifier::new("graphene_core::memo::MonitorNode")), | ||
| manual_composition: Some(generic!(T)), | ||
| skip_deduplication: true, | ||
| ..Default::default() | ||
| }, |
Comment on lines
+2029
to
+2034
| DocumentNode { | ||
| inputs: vec![NodeInput::node(NodeId(1), 0)], | ||
| implementation: DocumentNodeImplementation::ProtoNode(ProtoNodeIdentifier::new("graphene_core::memo::MemoNode")), | ||
| manual_composition: Some(generic!(T)), | ||
| ..Default::default() | ||
| }, |
| @@ -1138,6 +1138,97 @@ where | |||
| output_table | |||
| } | |||
|
|
|||
| /// Simplifies a polyline using the Ramer–Douglas–Peucker algorithm. | |||
| #[node_macro::node(category("Vector: Modifier"), name("Decimate"), path(graphene_core::vector))] | |||
There was a problem hiding this comment.
You don't need to specify the name here.
|
|
||
| /// Calculates the perpendicular distance from a point to a line defined by two points. | ||
| fn perpendicular_distance(point: DVec2, line_start: DVec2, line_end: DVec2) -> f64 { | ||
| let num = ((line_end.y - line_start.y) * point.x - (line_end.x - line_start.x) * point.y + line_end.x * line_start.y - line_end.y * line_start.x).abs(); |
There was a problem hiding this comment.
Can be simplified with project onto.
| return points.to_vec(); | ||
| } | ||
|
|
||
| let (_first, _lastt) = (0, points.len() - 1); |
| return points.to_vec(); | ||
| } | ||
|
|
||
| let (_first, _lastt) = (0, points.len() - 1); |
There was a problem hiding this comment.
Please don't prefix local variables with an underscore. That usually signifies that they are unused.
| let (_first, _lastt) = (0, points.len() - 1); | ||
|
|
||
| // For closed paths, treat as open for simplification, then close at the end | ||
| let (_first, _last, _is_closed) = if closed && points.len() > 2 { (0, points.len() - 1, true) } else { (0, points.len() - 1, false) }; |
There was a problem hiding this comment.
Line could be simplified to
let is_closed = closed && points.len() > 2;Since the other variables don't change and were already defined.
| } | ||
|
|
||
| if dmax > epsilon { | ||
| let mut rec_results1 = douglas_peucker(&points[_first..=index], epsilon, false); |
There was a problem hiding this comment.
since first is always zero, this could just be points[..=index]
|
|
||
| if dmax > epsilon { | ||
| let mut rec_results1 = douglas_peucker(&points[_first..=index], epsilon, false); | ||
| let mut rec_results2 = douglas_peucker(&points[index..=_last], epsilon, false); |
There was a problem hiding this comment.
Since last is always the last index, this could just be points[index..]
| @@ -2005,6 +2005,103 @@ fn static_nodes() -> Vec<DocumentNodeDefinition> { | |||
| description: Cow::Borrowed("Convert vector geometry into a polyline composed of evenly spaced points."), | |||
| properties: Some("sample_polyline_properties"), | |||
| }, | |||
| DocumentNodeDefinition { | |||
There was a problem hiding this comment.
You don't usually need to manually define the document node definition as it can be automagically generated.
Keavon
force-pushed
the
master
branch
4 times, most recently
from
ec51271 to
e025103
Compare
|
Hi, checking in on the latest status. This currently doesn't compile. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new node "Decimate" which uses the Ramer-Douglas-Peucker algorithm