Merge pull request #7 from Irev-Dev/update-polyRoundExtrude-api-a-little

Irev-Dev · web-flow · commit bf97548f88ef · 2020-08-16T08:36:09.000+10:00
Change polyRoundExtrude h to length in the api for consistency
diff --git a/polyround.scad b/polyround.scad
@@ -159,8 +159,8 @@ let(
   finalPolyhedronFaces
 ];
 
-module polyRoundExtrude(radiiPoints,h=5,r1=1,r2=1,fn=10,convexity=10) {
-  polyhedronPointsNFaces=extrudePolygonWithRadius(radiiPoints,h,r1,r2,fn);
+module polyRoundExtrude(radiiPoints,length=5,r1=1,r2=1,fn=10,convexity=10) {
+  polyhedronPointsNFaces=extrudePolygonWithRadius(radiiPoints,length,r1,r2,fn);
   polyhedron(points=polyhedronPointsNFaces[0], faces=polyhedronPointsNFaces[1], convexity=convexity);
 }
 
diff --git a/roundAnythingExamples.scad b/roundAnythingExamples.scad
@@ -203,8 +203,8 @@ module radiusExtrudeExample(){
 }
 
 module polyRoundExtrudeExample(){
-  radiiPointsbrah=[[10,0,10],[20,20,1.1],[8,7,10],[0,7,0.3],[5,3,0.1],[-4,0,1]];
-  polyRoundExtrude(radiiPointsbrah,2,0.5,-0.8,fn=8);
+  radiiPoints=[[10,0,10],[20,20,1.1],[8,7,10],[0,7,0.3],[5,3,0.1],[-4,0,1]];
+  polyRoundExtrude(radiiPoints,2,0.5,-0.8,fn=8);
 }
 
 module gridpattern(memberW = 4, sqW = 12, iter = 5, r = 3){

Original file line number	Diff line number	Diff line change
`@@ -159,8 +159,8 @@ let(`
`159`	`159`	`finalPolyhedronFaces`
`160`	`160`	`];`
`161`	`161`
`162`		`-module polyRoundExtrude(radiiPoints,h=5,r1=1,r2=1,fn=10,convexity=10) {`
`163`		`- polyhedronPointsNFaces=extrudePolygonWithRadius(radiiPoints,h,r1,r2,fn);`
	`162`	`+module polyRoundExtrude(radiiPoints,length=5,r1=1,r2=1,fn=10,convexity=10) {`
	`163`	`+ polyhedronPointsNFaces=extrudePolygonWithRadius(radiiPoints,length,r1,r2,fn);`
`164`	`164`	`polyhedron(points=polyhedronPointsNFaces[0], faces=polyhedronPointsNFaces[1], convexity=convexity);`
`165`	`165`	`}`
`166`	`166`
Original file line number	Diff line number	Diff line change
`@@ -203,8 +203,8 @@ module radiusExtrudeExample(){`
`203`	`203`	`}`
`204`	`204`
`205`	`205`	`module polyRoundExtrudeExample(){`
`206`		`- radiiPointsbrah=[[10,0,10],[20,20,1.1],[8,7,10],[0,7,0.3],[5,3,0.1],[-4,0,1]];`
`207`		`- polyRoundExtrude(radiiPointsbrah,2,0.5,-0.8,fn=8);`
	`206`	`+ radiiPoints=[[10,0,10],[20,20,1.1],[8,7,10],[0,7,0.3],[5,3,0.1],[-4,0,1]];`
	`207`	`+ polyRoundExtrude(radiiPoints,2,0.5,-0.8,fn=8);`
`208`	`208`	`}`
`209`	`209`
`210`	`210`	`module gridpattern(memberW = 4, sqW = 12, iter = 5, r = 3){`