[HDF5] Update - 6 - PropertiesIO and NodalSolutionStepVariablesIO #11488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5/update/properties_io
…5/update/properties_io
…5/update/properties_io
…5/update/properties_io
…5/update/properties_io
matekelemen
reviewed
Jun 3, 2025
applications/HDF5Application/custom_io/hdf5_nodal_solution_step_variables_io.cpp
Outdated
Show resolved
Hide resolved
matekelemen
reviewed
Jun 16, 2025
applications/HDF5Application/custom_utilities/container_io_utils.h
Outdated
Show resolved
Hide resolved
Comment on lines
+681
to
+683
| } else { | ||
| // do nothing | ||
| } |
There was a problem hiding this comment.
Suggested change
| } else { | |
| // do nothing | |
| } | |
| } |
applications/HDF5Application/custom_utilities/container_io_utils.h
Outdated
Show resolved
Hide resolved
applications/HDF5Application/custom_utilities/container_io_utils.h
Outdated
Show resolved
Hide resolved
| it->SetSolutionStepVariablesList(&r_variables_list); | ||
| } | ||
| block_for_each(rModelPart.Nodes(), [&r_variables_list](auto& rNode) { | ||
| rNode.SetSolutionStepVariablesList(&r_variables_list); |
There was a problem hiding this comment.
hm
is this thread safe?
There was a problem hiding this comment.
I think so, since it is setting a pointer within the rNode.
Comment on lines
+107
to
+110
| if (element.Id % 2 == 0): | ||
| element.SetValue(DISPLACEMENT, Vector([random.random(), random.random(), random.random()])) | ||
| element.SetValue(VELOCITY, Vector([random.random(), random.random(), random.random()])) | ||
| if (element.Id % 3 == 0): |
There was a problem hiding this comment.
I know randoms have been used in these tests before, but I really dislike the idea of unreproducible tests.
applications/HDF5Application/tests/test_hdf5_model_part_io_mpi.py
Outdated
Show resolved
Hide resolved
applications/HDF5Application/tests/test_hdf5_model_part_io_mpi.py
Outdated
Show resolved
Hide resolved
…ls.h Co-authored-by: Máté Kelemen <44344022+matekelemen@users.noreply.github.com>
…ls.h Co-authored-by: Máté Kelemen <44344022+matekelemen@users.noreply.github.com>
…ies.h Co-authored-by: Máté Kelemen <44344022+matekelemen@users.noreply.github.com>
…ies.h Co-authored-by: Máté Kelemen <44344022+matekelemen@users.noreply.github.com>
Co-authored-by: Máté Kelemen <44344022+matekelemen@users.noreply.github.com>
…ies.h Co-authored-by: Máté Kelemen <44344022+matekelemen@users.noreply.github.com>
matekelemen
reviewed
Jun 20, 2025
Comment on lines
44
to
45
| IndexType start_index, block_size; | ||
| std::tie(start_index, block_size) = StartIndexAndBlockSize(rFile, rPrefix + "/Properties/"); |
applications/HDF5Application/custom_io/hdf5_container_component_io.cpp
Outdated
Show resolved
Hide resolved
applications/HDF5Application/custom_io/hdf5_container_component_io.cpp
Outdated
Show resolved
Hide resolved
…t_io.cpp Co-authored-by: Máté Kelemen <44344022+matekelemen@users.noreply.github.com>
…t_io.cpp Co-authored-by: Máté Kelemen <44344022+matekelemen@users.noreply.github.com>
matekelemen
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Update
PropertiesIOandNodalSolutionStepVariablesIO. This removes theLocalGhostSplittingUtilityas well.🆕 Changelog
PropertiesIONodalSolutionStepVariablesIO