-
Notifications
You must be signed in to change notification settings - Fork 261
[Core] Refactor QEF Utility (QuadraticErrorFunction
). Replace eigenvalue computation with SVD
#13214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…modernized constructors
…perations and improve code clarity
… matrix operations and remove legacy eigenvalue calculations
…unction for consistency
@AriadnaCortesDanes can you review this? |
my only comment, without really understanding the code, is that SVD is more expensive than standard eigenvalue calculation for square matrices |
It is more expensive, but it is the proper thing to do. In fact the rare thing was it was working until now. @pooyan-dadvand agrees this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactor looks good to me :)
📝 Description
Summary
This PR involves modifications across three files:
test_qef_utility.cpp
,qef_utility.cpp
, andqef_utility.h
. The changes primarily focus on:Code Refactoring:
New Methods Added:
FirstEnd
andSecondEnd
for computing the endpoints of edges within a bounding box.Clean up test
TODO
🆕 Changelog
SVDUtils
to accept any kind of matrix as input, instead of justMatrix
type #13201