Skip to content

[GeoMechanicsApplication] Attempt several variants of function name 'User_Mod' when loading a UDSM #13530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 17, 2025

Conversation

avdg81
Copy link
Contributor

@avdg81 avdg81 commented Jun 16, 2025

📝 Description
When loading function User_Mod from a UDSM shared library account for the fact that several casing variants may have been used: User_Mod, User_mod, USER_MOD, and user_mod.

avdg81 added 4 commits June 16, 2025 15:03
So far, this is only done for the Windows build.
Moved adding the GFortran function names to a helper function. Also renamed the other helper function.
We now follow more strictly the UDSM documentation (i.e. 'User_Mod' and 'User_mod') as well as 'USER_MOD'.
Its implementation is now in line with `loadUDSMWindows`.
@avdg81 avdg81 requested a review from WPK4FEM June 16, 2025 14:28
@avdg81 avdg81 self-assigned this Jun 16, 2025
@avdg81 avdg81 requested a review from a team as a code owner June 16, 2025 14:28
@avdg81 avdg81 added the GeoMechanics Issues related to the GeoMechanicsApplication label Jun 16, 2025
@avdg81 avdg81 linked an issue Jun 16, 2025 that may be closed by this pull request
Copy link
Contributor

@WPK4FEM WPK4FEM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my question were answered by sitting side by side.

@github-project-automation github-project-automation bot moved this from In progress to Reviewer approved in GeoMechanicsApplication (Deltares) Jun 16, 2025
@avdg81 avdg81 enabled auto-merge (squash) June 17, 2025 08:59
@avdg81 avdg81 merged commit 9ede420 into master Jun 17, 2025
11 checks passed
@avdg81 avdg81 deleted the geo/13528-support-USER_MOD-when-loading-udsm branch June 17, 2025 12:17
@github-project-automation github-project-automation bot moved this from Reviewer approved to Done in GeoMechanicsApplication (Deltares) Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GeoMechanics Issues related to the GeoMechanicsApplication
Development

Successfully merging this pull request may close these issues.

[GeoMechanicsApplication] Support USER_MOD symbol in DLL loading
3 participants