Create Surrogate boundary from NURBS file #13535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickNick9
reviewed
Jun 17, 2025
| @@ -224,6 +223,143 @@ void SnakeSbmProcess::CreateTheSnakeCoordinates( | |||
| } | |||
| } | |||
| } | |||
| else if (rSkinModelPartInitial.Geometries().size()>0) // if the skin model part is defined by nurbs geometries | |||
| { | |||
| const int n_initial_points_for_side = 5000; | |||
There was a problem hiding this comment.
// TODO:
comment saying that you will implement soon the closest-point projection and therefore here we can set 10 or 100 I don't know
There was a problem hiding this comment.
Or this could be a user input
| SizeType count_split = 0; | ||
| while (((knot_span_u_point_split == rKnotSpansUV[0][0] && knot_span_v_point_split == rKnotSpansUV[1][0]) || | ||
| (knot_span_u_point_split == rKnotSpansUV[0][1] && knot_span_v_point_split == rKnotSpansUV[1][1]) ) | ||
| && (count_split < 5)) |
There was a problem hiding this comment.
can you explain better why you need this count_split?
| && (count_split < 5)) | ||
| { | ||
| count_split++; | ||
| local_coords_split[0] = (0.75*rLocalCoords[0] + 0.25*rLocalCoords[1]); |
There was a problem hiding this comment.
Is there a cleaner way to do this?
|
|
||
| p_cond->SetValue(CONDITION_NAME, condition_name); | ||
| //FIXME: | ||
| // p_cond->SetValue(LAYER_NAME, layer_name); |
There was a problem hiding this comment.
The LAYER_NAME variable still has to be introduced in Kratos. It will be done in the next PR
NickNick9
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Extend the "snake_sbm_process" for the creation of surrogate boundaries from exact NURBS geometries.
Please mark the PR with appropriate tags:
🆕 Changelog