Skip to content

Commit 49a8390

Browse files
Thomas StuartAndroid Build Coastguard Worker
Thomas Stuart
authored and
Android Build Coastguard Worker
committed
enforce the calling package is the default dialer for VisualVoicemail
In the docs for setVisualVoicemailSmsFilterSettings, they state that the callingPackage needs to be the default dialer. However, server side, there is no enforcement for this. Now, every client is verified to be the default dialer, system dialer, or carrier visual voicemail app before changing the settings for visual voicemail. Bug: 308932906 Test: CTS (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:17a3adcb99b587027be2bebe9718457df689b4b4) Merged-In: I951d7783f5c425c03768efb7aee7a38e299e6536 Change-Id: I951d7783f5c425c03768efb7aee7a38e299e6536
1 parent d42a6a4 commit 49a8390

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/com/android/phone/PhoneInterfaceManager.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -3788,7 +3788,7 @@ public String getVisualVoicemailPackageName(String callingPackage, String callin
37883788
public void enableVisualVoicemailSmsFilter(String callingPackage, int subId,
37893789
VisualVoicemailSmsFilterSettings settings) {
37903790
mAppOps.checkPackage(Binder.getCallingUid(), callingPackage);
3791-
3791+
enforceVisualVoicemailPackage(callingPackage, subId);
37923792
final long identity = Binder.clearCallingIdentity();
37933793
try {
37943794
VisualVoicemailSmsFilterConfig.enableVisualVoicemailSmsFilter(
@@ -3801,7 +3801,7 @@ public void enableVisualVoicemailSmsFilter(String callingPackage, int subId,
38013801
@Override
38023802
public void disableVisualVoicemailSmsFilter(String callingPackage, int subId) {
38033803
mAppOps.checkPackage(Binder.getCallingUid(), callingPackage);
3804-
3804+
enforceVisualVoicemailPackage(callingPackage, subId);
38053805
final long identity = Binder.clearCallingIdentity();
38063806
try {
38073807
VisualVoicemailSmsFilterConfig.disableVisualVoicemailSmsFilter(

0 commit comments

Comments
 (0)