Skip to content

build(deps): bump the cargo group across 2 directories with 1 update #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Mar 18, 2025

Bumps the cargo group with 1 update in the /userspace/ksud_magic directory: zip.
Bumps the cargo group with 1 update in the /userspace/ksud_overlayfs directory: zip.

Updates zip from 2.2.2 to 2.3.0

Release notes

Sourced from zip's releases.

v2.3.0

🚀 Features

  • Add support for NTFS extra field (#279)

🐛 Bug Fixes

  • (test) Conditionalize a zip64 doctest (#308)
  • fix failing tests, remove symlink loop check
  • Canonicalize output path to avoid false negatives
  • Symlink handling in stream extraction
  • Canonicalize output paths and symlink targets, and ensure they descend from the destination

⚙️ Miscellaneous Tasks

  • Fix clippy and cargo fmt warnings (#310)

v2.2.3

🚜 Refactor

  • Change the inner structure of DateTime (#267)

⚙️ Miscellaneous Tasks

  • cargo fix --edition
Changelog

Sourced from zip's changelog.

2.3.0 - 2025-03-16

🚀 Features

  • Add support for NTFS extra field (#279)

🐛 Bug Fixes

  • (test) Conditionalize a zip64 doctest (#308)
  • fix failing tests, remove symlink loop check
  • Canonicalize output path to avoid false negatives
  • Symlink handling in stream extraction
  • Canonicalize output paths and symlink targets, and ensure they descend from the destination

⚙️ Miscellaneous Tasks

  • Fix clippy and cargo fmt warnings (#310)

2.2.3 - 2025-02-26

🚜 Refactor

  • Change the inner structure of DateTime (#267)

⚙️ Miscellaneous Tasks

  • cargo fix --edition
Commits
  • 6eab5f5 chore: release v2.3.0 (#300)
  • e4aee20 implement ZipFile::options + refactor options normalization (#305)
  • ea8a7bb fix(test): Conditionalize a zip64 doctest (#308)
  • 365c81a Use xz2 crate instead of a custom implementation (#306)
  • ae94b34 chore: Fix clippy and cargo fmt warnings (#310)
  • a2e062f Merge commit from fork
  • 0199ac2 Simplify handling for symlink targets
  • 977bb94 fix failing tests, remove symlink loop check
  • 3cb29e7 Partial fix for tests
  • 2182b07 Refactor
  • Additional commits viewable in compare view

Updates zip from 2.2.2 to 2.3.0

Release notes

Sourced from zip's releases.

v2.3.0

🚀 Features

  • Add support for NTFS extra field (#279)

🐛 Bug Fixes

  • (test) Conditionalize a zip64 doctest (#308)
  • fix failing tests, remove symlink loop check
  • Canonicalize output path to avoid false negatives
  • Symlink handling in stream extraction
  • Canonicalize output paths and symlink targets, and ensure they descend from the destination

⚙️ Miscellaneous Tasks

  • Fix clippy and cargo fmt warnings (#310)

v2.2.3

🚜 Refactor

  • Change the inner structure of DateTime (#267)

⚙️ Miscellaneous Tasks

  • cargo fix --edition
Changelog

Sourced from zip's changelog.

2.3.0 - 2025-03-16

🚀 Features

  • Add support for NTFS extra field (#279)

🐛 Bug Fixes

  • (test) Conditionalize a zip64 doctest (#308)
  • fix failing tests, remove symlink loop check
  • Canonicalize output path to avoid false negatives
  • Symlink handling in stream extraction
  • Canonicalize output paths and symlink targets, and ensure they descend from the destination

⚙️ Miscellaneous Tasks

  • Fix clippy and cargo fmt warnings (#310)

2.2.3 - 2025-02-26

🚜 Refactor

  • Change the inner structure of DateTime (#267)

⚙️ Miscellaneous Tasks

  • cargo fix --edition
Commits
  • 6eab5f5 chore: release v2.3.0 (#300)
  • e4aee20 implement ZipFile::options + refactor options normalization (#305)
  • ea8a7bb fix(test): Conditionalize a zip64 doctest (#308)
  • 365c81a Use xz2 crate instead of a custom implementation (#306)
  • ae94b34 chore: Fix clippy and cargo fmt warnings (#310)
  • a2e062f Merge commit from fork
  • 0199ac2 Simplify handling for symlink targets
  • 977bb94 fix failing tests, remove symlink loop check
  • 3cb29e7 Partial fix for tests
  • 2182b07 Refactor
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps the cargo group with 1 update in the /userspace/ksud_magic directory: [zip](https://github.com/zip-rs/zip2).
Bumps the cargo group with 1 update in the /userspace/ksud_overlayfs directory: [zip](https://github.com/zip-rs/zip2).


Updates `zip` from 2.2.2 to 2.3.0
- [Release notes](https://github.com/zip-rs/zip2/releases)
- [Changelog](https://github.com/zip-rs/zip2/blob/master/CHANGELOG.md)
- [Commits](zip-rs/zip2@v2.2.2...v2.3.0)

Updates `zip` from 2.2.2 to 2.3.0
- [Release notes](https://github.com/zip-rs/zip2/releases)
- [Changelog](https://github.com/zip-rs/zip2/blob/master/CHANGELOG.md)
- [Commits](zip-rs/zip2@v2.2.2...v2.3.0)

---
updated-dependencies:
- dependency-name: zip
  dependency-type: direct:production
  dependency-group: cargo
- dependency-name: zip
  dependency-type: direct:production
  dependency-group: cargo
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update rust code labels Mar 18, 2025
LoveDoLove pushed a commit that referenced this pull request Jul 12, 2025
…rules() (#2646)

When kernel is compiled with CONFIG_DEBUG_ATOMIC_SLEEP enabled, it
prints the following splat in dmesg during post boot:

[ 6.739169] init: Opening SELinux policy
[ 6.751520] init: Loading SELinux policy
[ 6.894684] SELinux: policy capability network_peer_controls=1 [
6.894688] SELinux: policy capability open_perms=1 [ 6.894690] SELinux:
policy capability extended_socket_class=1 [ 6.894691] SELinux: policy
capability always_check_network=0 [ 6.894693] SELinux: policy capability
cgroup_seclabel=0 [ 6.894695] SELinux: policy capability
nnp_nosuid_transition=1 [ 7.214323] selinux: SELinux: Loaded file
context from: [ 7.214332] selinux:
/system/etc/selinux/plat_file_contexts [ 7.214339] selinux:
/system_ext/etc/selinux/system_ext_file_contexts [ 7.214345] selinux:
/product/etc/selinux/product_file_contexts [ 7.214350] selinux:
/vendor/etc/selinux/vendor_file_contexts [ 7.214356] selinux:
/odm/etc/selinux/odm_file_contexts [ 7.216398] KernelSU:
/system/bin/init argc: 2
[ 7.216401] KernelSU: /system/bin/init first arg: second_stage [
7.216403] KernelSU: /system/bin/init second_stage executed [ 7.216506]
BUG: sleeping function called from invalid context at
security/selinux/ss/hashtab.c:47 [ 7.216512] in_atomic(): 0,
irqs_disabled(): 0, non_block: 0, pid: 1, name: init [ 7.216516]
preempt_count: 0, expected: 0
[ 7.216518] RCU nest depth: 1, expected: 0
[ 7.216524] CPU: 6 PID: 1 Comm: init Not tainted
5.4.289-Scarlet-v2.0-beta3 #1 [ 7.216526] Hardware name: redwood based
Qualcomm Technologies, Inc. SM7325 (DT) [ 7.216528] Call trace:
[ 7.216536] dump_backtrace+0x0/0x210
[ 7.216539] show_stack+0x14/0x20
[ 7.216544] dump_stack+0x9c/0xec
[ 7.216548] __might_resched+0x1f0/0x210
[ 7.216552] hashtab_insert+0x38/0x230
[ 7.216557] add_type+0xd4/0x2e0
[ 7.216559] ksu_type+0x24/0x60
[ 7.216562] apply_kernelsu_rules+0xa8/0x650
[ 7.216565] ksu_handle_execveat_ksud+0x2a8/0x460
[ 7.216568] ksu_handle_execveat+0x2c/0x60
[ 7.216571] __arm64_sys_execve+0xe8/0xf0
[ 7.216574] el0_svc_common+0xf4/0x1a0
[ 7.216577] do_el0_svc+0x2c/0x40
[ 7.216579] el0_sync_handler+0x18c/0x200
[ 7.216582] el0_sync+0x140/0x180

This is because apply_kernelsu_rules() uses rcu_read_lock() to protect
SELinux policy modifications. However, cond_resched() from
hashtab_insert() at security/selinux/ss/hashtab.c is internally called
and it sleeps which is illegal under an RCU read-side critical section.

While replacing it with a spinlock would suppress the warning, this is
fundamentally incorrect because sleeping is illegal while holding a
spinlock and spinlock would turn off preemption which isn't an ideal
solution since it intentionally turns off rescheduling, and can lead to
deadlocks.

Instead, replace the RCU lock with a mutex lock. Mutex lock allows
sleeping when necessary, which is appropriate here because
apply_kernelsu_rules() runs in process context, not in atomic or
interrupt context. As apply_kernelsu_rules() is invoked only once during
post boot (SYSTEM_RUNNING), the mutex lock does not introduce any major
runtime performance regression and provides correct synchronization.

Fixes: tiann/KernelSU#2637

Signed-off-by: Tashfin Shakeer Rhythm <tashfinshakeerrhythm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants