Ignore formatting codes when calculting the maximum line length. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh and, thanks for the plugin! |
|
Thanks for the suggestion! I agree, that was an oversight, thanks for pointing it out! I'm very busy at the moment so it may take me a few days to test and deploy a new version, but I appreciate your patience :) |
|
Adopted on my branch in 1.2.0 https://github.com/NotAlexNoyle/SudoSigns-OG |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids being blocked from setting a message that is acceptable [length-wise] but had formatting codes chucked in. You can test with a message such as
Click here forwhich would surpass 15 characters if you add a<o the front of it.