Skip to content

Conversation

d0cd
Copy link
Collaborator

@d0cd d0cd commented Feb 26, 2023

This PR,

  • Removes AssociatedConstants from the AST
  • Refactors the Visitor, Reconstructor, and Consumer traits.
  • Refactors the code generation pass to use the Consumer.

@d0cd d0cd changed the title [Refactor] Use the Consumer trait for code generation. [Refactor] Use the Consumer pattern for code generation. Feb 26, 2023
@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

❌ Patch coverage is 78.70036% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.06%. Comparing base (c8f6089) to head (3532dcb).
⚠️ Report is 1216 commits behind head on testnet3.

Files with missing lines Patch % Lines
.../passes/src/code_generation/generate_statements.rs 68.96% 18 Missing ⚠️
...ler/passes/src/code_generation/generate_program.rs 78.94% 12 Missing ⚠️
...iler/passes/src/type_checking/check_expressions.rs 76.47% 12 Missing ⚠️
compiler/ast/src/passes/reconstructor.rs 66.66% 6 Missing ⚠️
compiler/passes/src/code_generation/generator.rs 76.47% 4 Missing ⚠️
...passes/src/code_generation/generate_expressions.rs 90.00% 3 Missing ⚠️
.../src/static_single_assignment/rename_expression.rs 89.28% 3 Missing ⚠️
...mpiler/passes/src/flattening/flatten_expression.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           testnet3    #2282      +/-   ##
============================================
+ Coverage     77.94%   78.06%   +0.12%     
============================================
  Files           150      148       -2     
  Lines          4571     4619      +48     
  Branches       4569     4617      +48     
============================================
+ Hits           3563     3606      +43     
- Misses         1008     1013       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d0cd
Copy link
Collaborator Author

d0cd commented Aug 19, 2025

Closing due to inactivity.

@d0cd d0cd closed this Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant