fix(ui5-tokenizer): sync popover list items with token text changes #11854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add invalidateOnChildChange config to tokens slot to watch for text property changes to ensure popover list items automatically update when token text is modified fixes: #11825
clean the merge conflict markers
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that popover list items reflect updates to token text by invalidating the slot when a child's text property changes, and adds Cypress tests to verify this behavior.
- Added
invalidateOnChildChangeslot configuration to watch token text changes. - Introduced Cypress tests for single and multiple token text updates in the popover.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/main/src/Tokenizer.ts | Added invalidateOnChildChange to tokens slot configuration. |
| packages/main/cypress/specs/Tokenizer.cy.tsx | New tests verifying popover list item text updates on token changes. |
Comments suppressed due to low confidence (1)
packages/main/src/Tokenizer.ts:336
- [nitpick] Consider adding a brief JSDoc comment above the
invalidateOnChildChangeslot config to explain its purpose (watchingtextproperty changes) so future maintainers understand why this is needed.
invalidateOnChildChange: {
use the StandardListItem 'text' property instead of slot to ensure correct text rendering in popover list items
| <Token text="Germany"></Token> | ||
| </Tokenizer> | ||
| ); | ||
|
|
There was a problem hiding this comment.
select by [custom-tag] instead of id where it's possible
| const token = $token.get(0) as Token; | ||
| token.text = "Updated Text"; | ||
| }); | ||
|
|
There was a problem hiding this comment.
cy.get("#token-to-modify")
.invoke("prop", "text", "Updated Text");
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ListItemStandardelement and not rendered as its default slot, because after feat(ui5-li): add text wrapping support #11108 dynamic updates in it doesn't get reflected (do not cause re-rendering of the list item).Note: The problem in the ListItemStandard occurs only with
wrappingTypeset toNormalbecause it uses theui5-expandable-textcomponent. That component has its owntextproperty which is getting updated when thetextproperty of theListItemStandartis updated, but not when its slot is.invalidateOnChildChangeconfig to tokens slot to watch for text property changes to ensure popover list items automatically update when token text is modifiedfixes: #11825