Skip to content
This repository was archived by the owner on Oct 20, 2023. It is now read-only.

Commit 61c1bbb

Browse files
Alorenmarchello2000
authored andcommitted
fix(bom): Fix generated pom.xml to omit invalid lombok declaration (spinnaker#437)
compileOnly dependency should not be added to generated pom.xml, see discussion: https://discuss.gradle.org/t/publishing-plugin-should-respect-compileonly-configuration/22903/2 see related commit: nebula-plugins/nebula-publishing-plugin@a5432aa
1 parent f228238 commit 61c1bbb

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

build.gradle

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,9 @@ buildscript {
2424
classpath "com.netflix.spinnaker.gradle:spinnaker-dev-plugin:$spinnakerGradleVersion"
2525
if (Boolean.valueOf(enablePublishing)) {
2626
classpath "com.netflix.spinnaker.gradle:spinnaker-gradle-project:$spinnakerGradleVersion"
27+
// TODO: nebula-publishing-plugin version override should be removed as soon as spinnaker-gradle-project is updated
28+
// this override is needed to omit compileOnly dependencies from generated pom.xml
29+
classpath "com.netflix.nebula:nebula-publishing-plugin:12.0.1"
2730
}
2831
}
2932
}

fiat-bom/fiat-bom.gradle

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@
1717
apply plugin: "java-platform"
1818
apply plugin: "maven-publish"
1919

20-
// without this building the pom fails when using the Nebula publishing plugin
21-
configurations {
22-
create("compileOnly")
23-
}
24-
2520
javaPlatform {
2621
allowDependencies()
2722
}

0 commit comments

Comments
 (0)