Refactor filesystem event handler into a separate section #1190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the generatecmd::Run function into two functions, to reduce complexity. In doing so, I noticed that a few instances of error handling operate by defining a new variable
err
and logging and/or returning it immediately, while another instance assigns the preexisting symbolerr
which represents the return value. Because this logic was very unclear, I renamed the top-levelerr
toproxyError
(since it is only used for the proxy) and removed the named-return value so that any assignment toerr
must be its own contained definition to make for better readability.The diff shows that
StartProxy
was changed (actually moved), but that is just due to the addition of a new function (and removal of part of another) which confuses the Git diff algorithm.