-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]: Spark 51272 51016 combined: For testing of HA Test #50263
Open
ahshahid
wants to merge
57
commits into
apache:master
Choose a base branch
from
ahshahid:SPARK-51272--51016-combined
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in retrying all partitions in case of indeterministic shuffle keys
…on which will fail if all partitions are not retried for indeterministic shuffle stage
…minism via curried constructor of AttributeReference, as per feedback. Renamed the boolean
…minism via curried constructor of AttributeReference, as per feedback. Renamed the boolean
…Outer to replicate the bug.
… relying on concurrent processing of DagEvent, instead relying on concurrent addition of event to the event loop queue
…race condition exposed.
… always be in a single thread of EventLoop and that when ResubmitFailedStages event is submitted, though it is done by MessageScheduler ( a separate threadpool, but it is still doing post to the event loop's queue instead of direct onRecieve invocation, the read/write locks in stage are not needed
…on of beforeEach and afterEach in test
…eeds fixes for SPARK-51272 and SPARK-51016 for it to consistently pass
…eeds fixes for SPARK-51272 and SPARK-51016 for it to consistently pass
…eeds fixes for SPARK-51272 and SPARK-51016 for it to consistently pass
…of results to be retried, if result stage is inDeterminate but failed shuffle stage is determinate
…( stage submitted and stage completed to kill the executors)
…yarn with test scope
…yarn with test scope
…tions is not equal to total partitions and resultstage is inDeterminate. Though with the current PR, this is not expected, unless there still remains a window of race.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?