[SPARK-51525][SQL] Collation field for Desc As JSON StringType #50290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asl3
changed the title
cloud-fan
approved these changes
Mar 17, 2025
srielau
reviewed
Mar 17, 2025
| columns = Some(List( | ||
| TableColumn("c1", Type("string", collation = Some("UNICODE_CI"))), | ||
| TableColumn("c2", Type("string", collation = Some("UNICODE_RTRIM"))), | ||
| TableColumn("c3", Type("string", collation = Some("fr"))), |
There was a problem hiding this comment.
Curious, why is the case not normalized? For builtin collations they should be, no?
srielau
approved these changes
Mar 17, 2025
|
There is still a test failure |
dejankrak-db
approved these changes
Mar 17, 2025
| case stringType: StringType => | ||
| JObject( | ||
| "name" -> JString("string"), | ||
| "collation" -> JString(stringType.collationName) |
There was a problem hiding this comment.
Is the plan to add a table collation as a top-level field to JSON in a separate PR?
There was a problem hiding this comment.
yes I'll make a separate PR to add the top-level table collation field
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/DescribeTableSuite.scala
Show resolved
Hide resolved
|
thanks, merging to master/4.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Mar 18, 2025
### What changes were proposed in this pull request?
Add a collation field for Desc As JSON StringType.
For example:
```
"columns":[{"name":"c1","type":{"name":"string", "collation":"UNICODE_CI"}
```
or the default collation value:
```
"columns":[{"name":"c1","type":{"name":"string", "collation":"UTF8_BINARY"}
```
### Why are the changes needed?
Add support for collation data type in Desc As JSON
### Does this PR introduce _any_ user-facing change?
Yes, it affects the output of Desc As JSON for collation data type.
### How was this patch tested?
Added test in DescribeTableSuite
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #50290 from asl3/asl3/collation-descasjson.
Authored-by: Amanda Liu <amanda.liu@databricks.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
(cherry picked from commit 513a080)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a collation field for Desc As JSON StringType.
For example:
or the default collation value:
Why are the changes needed?
Add support for collation data type in Desc As JSON
Does this PR introduce any user-facing change?
Yes, it affects the output of Desc As JSON for collation data type.
How was this patch tested?
Added test in DescribeTableSuite
Was this patch authored or co-authored using generative AI tooling?
No