Skip to content

[PM-22391] display simple dialog when advanced matching strategy selected for login ciphers #15260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dan-livefront
Copy link
Collaborator

@dan-livefront dan-livefront commented Jun 19, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-22391

📔 Objective

Add advanced‐match confirmation dialog & dynamic hints

Advanced‐match dialog
When a user selects an advanced URI match strategy (StartsWith or Regular Expression) on an individual cipher, a modal warning is displayed.

Dynamic hints
The UriOptionComponent now shows hint text that updates based on the selected strategy—including specific warnings for StartsWith and RegEx options.

User flow

Continue → Applies the new advanced strategy

Cancel → Reverts the control back to its previous match strategy

Note:
This ticket is tracking known issue of label not updating as expected where select component is used

📸 Screenshots

Screenshot 1 Screenshot 2 Screenshot 3
Screenshot 4 Screenshot 5 Screenshot 6

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@dan-livefront dan-livefront self-assigned this Jun 19, 2025
…-matching-strategy-selected-for-login-ciphers
Copy link
Contributor

github-actions bot commented Jun 20, 2025

Logo
Checkmarx One – Scan Summary & Details880adb3e-7a44-4084-a536-95c13c3d5aa7

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 61.11111% with 14 lines in your changes missing coverage. Please review.

Project coverage is 37.14%. Comparing base (ab4af7d) to head (3de4850).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ll-options/advanced-uri-option-dialog.component.ts 31.25% 11 Missing ⚠️
...omponents/autofill-options/uri-option.component.ts 85.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15260   +/-   ##
=======================================
  Coverage   37.13%   37.14%           
=======================================
  Files        3271     3272    +1     
  Lines       94332    94367   +35     
  Branches    14218    14225    +7     
=======================================
+ Hits        35034    35055   +21     
- Misses      57849    57862   +13     
- Partials     1449     1450    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dan-livefront dan-livefront marked this pull request as ready for review June 20, 2025 18:51
@dan-livefront dan-livefront requested a review from a team as a code owner June 20, 2025 18:51
@jprusik jprusik changed the title Pm 22391 display simple dialog when advanced matching strategy selected for login ciphers [PM-22391] display simple dialog when advanced matching strategy selected for login ciphers Jun 25, 2025
dan-livefront and others added 2 commits June 26, 2025 15:01
…-matching-strategy-selected-for-login-ciphers
Copy link

sonarqubecloud bot commented Jul 3, 2025

@dan-livefront dan-livefront merged commit 0311d0a into main Jul 3, 2025
99 checks passed
@dan-livefront dan-livefront deleted the PM-22391-display-simple-dialog-when-advanced-matching-strategy-selected-for-login-ciphers branch July 3, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants