-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[PM-22391] display simple dialog when advanced matching strategy selected for login ciphers #15260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-22391] display simple dialog when advanced matching strategy selected for login ciphers #15260
Conversation
…-matching-strategy-selected-for-login-ciphers
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #15260 +/- ##
=======================================
Coverage 37.13% 37.14%
=======================================
Files 3271 3272 +1
Lines 94332 94367 +35
Branches 14218 14225 +7
=======================================
+ Hits 35034 35055 +21
- Misses 57849 57862 +13
- Partials 1449 1450 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…-matching-strategy-selected-for-login-ciphers
…-matching-strategy-selected-for-login-ciphers
…-matching-strategy-selected-for-login-ciphers
.../vault/src/cipher-form/components/autofill-options/advanced-uri-option-dialog.component.html
Show resolved
Hide resolved
libs/vault/src/cipher-form/components/autofill-options/advanced-uri-option-dialog.component.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Nick Krantz <125900171+nick-livefront@users.noreply.github.com>
…-matching-strategy-selected-for-login-ciphers
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-22391
📔 Objective
Add advanced‐match confirmation dialog & dynamic hints
Advanced‐match dialog
When a user selects an advanced URI match strategy (StartsWith or Regular Expression) on an individual cipher, a modal warning is displayed.
Dynamic hints
The UriOptionComponent now shows hint text that updates based on the selected strategy—including specific warnings for StartsWith and RegEx options.
User flow
Continue → Applies the new advanced strategy
Cancel → Reverts the control back to its previous match strategy
Note:
This ticket is tracking known issue of label not updating as expected where select component is used
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes