Skip to content

[PM-22854] Fix biometric setup not resetting the setting in browser #15267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

quexten
Copy link
Contributor

@quexten quexten commented Jun 20, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-22854

📔 Objective

The setup did not return early correctly in two places, and did not set the setup result in case authentication was cancelled, making the biometrics setting stay active. This fixes the behavior by returning early and setting the setup result properly.

📸 Screenshots

Screen.Recording.2025-06-20.at.13.58.05.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@quexten quexten marked this pull request as ready for review June 20, 2025 11:58
@quexten quexten requested a review from a team as a code owner June 20, 2025 11:58
@quexten quexten requested a review from rr-bw June 20, 2025 11:58
Copy link

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details6158f593-c833-4a61-8061-08be99f587b3

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36.90%. Comparing base (662a973) to head (d8c9920).
Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
.../auth/popup/settings/account-security.component.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15267   +/-   ##
=======================================
  Coverage   36.90%   36.90%           
=======================================
  Files        3225     3225           
  Lines       93192    93195    +3     
  Branches    14016    14016           
=======================================
+ Hits        34388    34396    +8     
+ Misses      57380    57375    -5     
  Partials     1424     1424           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@quexten quexten merged commit 963688b into main Jun 26, 2025
46 checks passed
@quexten quexten deleted the km/pm-22854/fix-cancelled-biometrics-setup branch June 26, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants