Skip to content

Hide card option from context menu when user is affected by card policy #15272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025

Conversation

differsthecat
Copy link
Member

@differsthecat differsthecat commented Jun 20, 2025

🎟️ Tracking

PM-20625

📔 Objective

Remove the 'Autofill card' option from the context menu if a user is part of an organization with the 'Remove card item type' policy on.

📸 Screenshots

Screen.Recording.2025-06-20.at.1.52.14.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@differsthecat differsthecat marked this pull request as ready for review June 20, 2025 17:57
@differsthecat differsthecat requested a review from a team as a code owner June 20, 2025 17:57
Copy link
Contributor

github-actions bot commented Jun 20, 2025

Logo
Checkmarx One – Scan Summary & Details4e4bb48b-5bbe-496e-99af-aea6108c3a40

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.90%. Comparing base (a4ef61e) to head (dacb827).
Report is 29 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/browser/src/background/main.background.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15272   +/-   ##
=======================================
  Coverage   36.89%   36.90%           
=======================================
  Files        3225     3225           
  Lines       93194    93201    +7     
  Branches    14017    14018    +1     
=======================================
+ Hits        34388    34394    +6     
- Misses      57381    57382    +1     
  Partials     1425     1425           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blackwood
blackwood previously approved these changes Jun 20, 2025
Copy link

@jprusik jprusik self-assigned this Jun 25, 2025
@jprusik jprusik merged commit 4003608 into main Jun 25, 2025
45 checks passed
@jprusik jprusik deleted the pm-20625-card-policy-context-menu branch June 25, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants