-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[SM-1273] Adding enums for additional event logs for secrets #15274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #15274 +/- ##
==========================================
- Coverage 37.11% 37.11% -0.01%
==========================================
Files 3267 3267
Lines 94231 94243 +12
Branches 14208 14208
==========================================
+ Hits 34971 34974 +3
- Misses 57812 57821 +9
Partials 1448 1448 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
….com/bitwarden/clients into SM-1273-AddAdditionalSecretEventLogs
57770de
|
🎟️ Tracking
📔 Objective
Show event logs for secrets when they are updated, edited, created or deleted by a user or a machine account.
📸 Screenshots
https://www.loom.com/share/9670bdbd7a374c0ab12d69cccd341e0e
Code explanation:
https://www.loom.com/share/70dd817fe7b54e31b51c4cba1589c1fc?sid=8cf47854-4584-40ef-9dcb-1721f38e7627
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes