Skip to content

[SM-1273] Adding enums for additional event logs for secrets #15274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 3, 2025

Conversation

cd-bitwarden
Copy link
Contributor

@cd-bitwarden cd-bitwarden commented Jun 20, 2025

🎟️ Tracking

📔 Objective

Show event logs for secrets when they are updated, edited, created or deleted by a user or a machine account.

📸 Screenshots

https://www.loom.com/share/9670bdbd7a374c0ab12d69cccd341e0e

Code explanation:
https://www.loom.com/share/70dd817fe7b54e31b51c4cba1589c1fc?sid=8cf47854-4584-40ef-9dcb-1721f38e7627

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jun 20, 2025

Logo
Checkmarx One – Scan Summary & Details4ee632ce-37ff-456d-b8ca-436687ab48ff

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jun 20, 2025

Codecov Report

Attention: Patch coverage is 21.42857% with 11 lines in your changes missing coverage. Please review.

Project coverage is 37.11%. Comparing base (24ac3b3) to head (7e8f09a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/web/src/app/core/event.service.ts 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15274      +/-   ##
==========================================
- Coverage   37.11%   37.11%   -0.01%     
==========================================
  Files        3267     3267              
  Lines       94231    94243      +12     
  Branches    14208    14208              
==========================================
+ Hits        34971    34974       +3     
- Misses      57812    57821       +9     
  Partials     1448     1448              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cd-bitwarden cd-bitwarden marked this pull request as ready for review June 24, 2025 17:21
@cd-bitwarden cd-bitwarden requested a review from a team as a code owner June 24, 2025 17:21
@cd-bitwarden cd-bitwarden requested a review from dani-garcia June 24, 2025 17:21
dani-garcia
dani-garcia previously approved these changes Jun 25, 2025
@cd-bitwarden cd-bitwarden dismissed stale reviews from dani-garcia and tangowithfoxtrot via 57770de July 2, 2025 18:15
@cd-bitwarden cd-bitwarden enabled auto-merge (squash) July 3, 2025 02:28
@cd-bitwarden cd-bitwarden requested a review from dani-garcia July 3, 2025 02:30
Copy link

sonarqubecloud bot commented Jul 3, 2025

@cd-bitwarden cd-bitwarden merged commit cef6a5e into main Jul 3, 2025
99 checks passed
@cd-bitwarden cd-bitwarden deleted the SM-1273-AddAdditionalSecretEventLogs branch July 3, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants