Skip to content

fix: cargo install git-delta --locked fails on systems with GCC 15 #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tquin
Copy link

@tquin tquin commented Jun 18, 2025

cargo install git-delta --locked currently fails on Fedora 42 due to the upgrade to GCC 15. This PR updates the Cargo.lock file to use the new onig 6.5.1 and onig_sys 69.9.1 versions. I believe these crates come from the direct dependency on bat.

Please see:

Thanks!

@tquin tquin changed the title fix: cargo install --locked fails on systems with GCC 15 fix: cargo install git-delta --locked fails on systems with GCC 15 Jun 18, 2025
@tquin
Copy link
Author

tquin commented Jun 18, 2025

Clippy is failing due to:

    Checking git-delta v0.18.2 (/home/runner/work/delta/delta)
error: using `contains()` instead of `iter().any()` is more efficient
  --> src/utils/tabs.rs:24:29
   |
24 |     if tab_cfg.replace() && line.as_bytes().iter().any(|c| *c == b'\t') {
   |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `line.as_bytes().contains(&b'\t')`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains
   = note: `-D clippy::manual-contains` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::manual_contains)]`

error: could not compile `git-delta` (bin "delta") due to 1 previous error
Error: Process completed with exit code 101.

I didn't touch that file with this PR, so I'm not sure why this wasn't an issue for previous PRs; maybe clippy had a new lint rule added recently.

Edit: The rule was added recently in Rust 1.87.0 last month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant