Skip to content

Add diverses improvements. #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2015
Merged

Add diverses improvements. #12

merged 1 commit into from
Apr 22, 2015

Conversation

thierryvolpiatto
Copy link
Member

  • helm-mu.el (helm-source-mu-contacts): Use helm-source-in-buffer and fuzzy.
    (helm-source-mu): Use helm-source-sync.
    (helm-mu-contacts-transformer): Filter out the reply github and noreply addresses.

* helm-mu.el (helm-source-mu-contacts): Use helm-source-in-buffer and fuzzy.
(helm-source-mu): Use helm-source-sync.
(helm-mu-contacts-transformer): Filter out the reply github and noreply addresses.
@tmalsburg
Copy link
Member

Thank you, Thierry. This helm source could indeed use some more attention but it works well enough for me and to my knowledge there are not too many other people using it.

I suppose I should add some more infrastructure for filtering contacts because there is a lot of rubbish among the results apart from the Github addresses.

@tmalsburg
Copy link
Member

helm-mu-contacts doesn't work properly with this PR applied. When I search for the string "Engelmann", I get matches like this

but I also get matches like this one:

  • Manuel Vitin skdj@googlemail.com

with the bold characters highlighted.

I'm using the current development version of Emacs and the current version of helm from MELPA.

@tmalsburg
Copy link
Member

The problem is not specific to helm-mu-contacts. Some other sources also show it, see emacs-helm/helm#991.

tmalsburg added a commit that referenced this pull request Apr 22, 2015
@tmalsburg tmalsburg merged commit d1c9475 into emacs-helm:master Apr 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants